installer: make OpenVSX URL configurable in the openvsx proxy

[Pothulapati]

Description

This PR adds a new OpenVSX object into the top-level Config field
to support configurations of the openvsx-proxy component. Currently,
Only URL field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

Signed-off-by: Tarun Pothulapati [email protected]

Related Issue(s)

Fixes #8224

How to test

Set openVSX.url to something else and do a ./installer render -c ./config.yaml | grep <something>

Release Notes

Make Open VSX upstream URL configurable in the installer for air-gap installations

Documentation

[mrsimonemms]

What happens if you run it with a config that doesn't have the openVSX object created? I'm just thinking about user's who create a new installation without updating their config

[codecov]

Codecov Report

Merging #8266 (3813f39) into main (ddc80c1) will decrease coverage by 4.72%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main   #8266      +/-   ##
=========================================
- Coverage   12.31%   7.59%   -4.73%     
=========================================
  Files          20      31      +11     
  Lines        1161    2172    +1011     
=========================================
+ Hits          143     165      +22     
- Misses       1014    2004     +990     
+ Partials        4       3       -1     

Flag	Coverage Δ
components-gitpod-cli-app	11.17% <ø> (ø)
components-local-app-app-darwin-amd64	?
components-local-app-app-darwin-arm64	?
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
install-installer-raw-app	4.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
...installer/pkg/components/ws-manager/rolebinding.go	0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go	0.00% <0.00%> (ø)
install/installer/pkg/common/storage.go	0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go	0.00% <0.00%> (ø)
install/installer/pkg/common/objects.go	0.00% <0.00%> (ø)
...nstall/installer/pkg/components/ws-manager/role.go	0.00% <0.00%> (ø)
...l/installer/pkg/components/ws-manager/tlssecret.go	0.00% <0.00%> (ø)
.../installer/pkg/components/ws-manager/deployment.go	0.00% <0.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc80c1...3813f39. Read the comment docs.

[corneliusludmann]

What happens if you run it with a config that doesn't have the openVSX object created? I'm just thinking about user's who create a new installation without updating their config

In my opinion, we should make all config values that have sensible default values optional in the config file. E.g., it should be totally fine to use a config like this:

apiVersion: v1
domain: gitpod.my-domain.example

That would also make generating config values for e.g. replicated easier.

I'll create an issue for this and we can discuss this there. When we agree on this, we can leave this pull request as is and handle your concern with a more general solution of using sensible default values of missing config properties.

[corneliusludmann]

Looks good to me. @Pothulapati Would you mind squashing the commits into one commit?

(By the way: I usually amend changes to the previous commit and force push them directly to the PR branch so that the Git history is always clean and ready to merge. You still see the history of changes in the PR on the Gitpod PR page and everyone can see diffs for each step even when you force push.)

[corneliusludmann]

Took the liberty and resolved the conflicts after we merged #8345. Hope, you're fine with that, @Pothulapati. 🙏

[akosyakov]

LGTM

[Pothulapati]

Thanks @corneliusludmann for doing that!