Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer] Make OpenVSX URL configurable #8224

Closed
corneliusludmann opened this issue Feb 15, 2022 · 1 comment · Fixed by #8266
Closed

[installer] Make OpenVSX URL configurable #8224

corneliusludmann opened this issue Feb 15, 2022 · 1 comment · Fixed by #8266
Assignees
@Pothulapati
Labels
component: install Terraform installation scripts, helm charts, installer images installer: needs interface change Change required to input, output or configuration file(s) team: delivery Issue belongs to the self-hosted team
Milestone
release/2022.03

Comments

@corneliusludmann
Copy link
Contributor

If users want to use their own OpenVSX instance (e.g. in an airgap installation), they need to configure their own OpenVSX URL.
@corneliusludmann corneliusludmann added component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team installer: needs interface change Change required to input, output or configuration file(s) labels Feb 15, 2022
@corneliusludmann corneliusludmann added this to the release/2022.03 milestone Feb 15, 2022
@corneliusludmann corneliusludmann mentioned this issue Feb 15, 2022
Closed
@Pothulapati Pothulapati self-assigned this Feb 16, 2022
@mrsimonemms
Copy link
Contributor

As part of this task, we should generate a new version of the example-config.yaml for the repo

gitpod-installer init > example-config.yaml

Pothulapati added a commit that referenced this issue Feb 17, 2022
@Pothulapati
installer: make OpenVSX URL configurable
9edebf7 
Fixes #8224

This PR adds a new `OpenVSX` object into the top-level `Config` field
to support configurations of the `openvsx-proxy` component. Currently,
Only `URL` field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati added a commit that referenced this issue Feb 17, 2022
@Pothulapati
installer: make OpenVSX URL configurable
6d799b3 
Fixes #8224

This PR adds a new `OpenVSX` object into the top-level `Config` field
to support configurations of the `openvsx-proxy` component. Currently,
Only `URL` field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

Signed-off-by: Tarun Pothulapati <[email protected]>
@Pothulapati Pothulapati mentioned this issue Feb 17, 2022
Merged
Pothulapati added a commit that referenced this issue Feb 19, 2022
@Pothulapati
installer: make OpenVSX URL configurable
d19ae75 
Fixes #8224

This PR adds a new `OpenVSX` object into the top-level `Config` field
to support configurations of the `openvsx-proxy` component. Currently,
Only `URL` field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

The URL is validated by using the validate go tags.

Signed-off-by: Tarun Pothulapati <[email protected]>
corneliusludmann pushed a commit that referenced this issue Feb 22, 2022
@Pothulapati @corneliusludmann
installer: make OpenVSX URL configurable
3813f39 
Fixes #8224

This PR adds a new `OpenVSX` object into the top-level `Config` field
to support configurations of the `openvsx-proxy` component. Currently,
Only `URL` field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

The URL is validated by using the validate go tags.

Signed-off-by: Tarun Pothulapati <[email protected]>
Repository owner moved this from ⚒In Progress to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Feb 22, 2022
roboquat pushed a commit that referenced this issue Feb 22, 2022
@Pothulapati @roboquat
installer: make OpenVSX URL configurable
d9b9f30 
Fixes #8224

This PR adds a new `OpenVSX` object into the top-level `Config` field
to support configurations of the `openvsx-proxy` component. Currently,
Only `URL` field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

The URL is validated by using the validate go tags.

Signed-off-by: Tarun Pothulapati <[email protected]>
mustard-mh pushed a commit that referenced this issue Feb 28, 2022
@Pothulapati @mustard-mh
installer: make OpenVSX URL configurable
dc4d36d 
Fixes #8224

This PR adds a new `OpenVSX` object into the top-level `Config` field
to support configurations of the `openvsx-proxy` component. Currently,
Only `URL` field is present. This is needed to support air-gap
instlalations where people are expected to host their own open-vsx.

This config is top-level and not under the workspace or IDE as this
configures the proxy, but not the IDE.

The URL is validated by using the validate go tags.

Signed-off-by: Tarun Pothulapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pothulapati Pothulapati

Labels
component: install Terraform installation scripts, helm charts, installer images installer: needs interface change Change required to input, output or configuration file(s) team: delivery Issue belongs to the self-hosted team
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
release/2022.03
Development

Successfully merging a pull request may close this issue.

installer: make OpenVSX URL configurable in the openvsx proxy gitpod-io/gitpod
3 participants
@mrsimonemms @Pothulapati @corneliusludmann