-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream imagebuild logs directly from pods #7899
Conversation
/werft run 👍 started the job as gitpod-build-gpl-7874-imagebuild-logs.9 |
Codecov Report
@@ Coverage Diff @@
## main #7899 +/- ##
==========================================
- Coverage 11.46% 10.20% -1.27%
==========================================
Files 20 18 -2
Lines 1177 1009 -168
==========================================
- Hits 135 103 -32
+ Misses 1039 905 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
01b9f84
to
ced21ef
Compare
351b1ab
to
5db1591
Compare
/werft run 👍 started the job as gitpod-build-gpl-7874-imagebuild-logs.17 |
/werft run 👍 started the job as gitpod-build-gpl-7874-imagebuild-logs.18 |
5db1591
to
3fd7b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: e713670d411534f3e37f15ad31ed52b2b99304c1
|
/hold to apply instance changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3fd7b84
to
1b4c753
Compare
…builds (incl. extra headers to access said URL) and store it in workspace
1b4c753
to
1129ace
Compare
did not actually try this, but image-builder and API changes look good. /lgtm |
LGTM label has been added. Git tree hash: 5ae979b6ca3262a6e075e23062b58251338adcde
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, JanKoehnlein, sagor999 Associated issue: #7874 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Streams log URLs from the
imagebuild
workspace directly instead viaimage-builder-mk3
, which made it cluster dependent.Basically
server
-> (cluster-local)image-builder-mk3
->imgbuild
workspaceserver
->imgbuild
workspaceRelated Issue(s)
Fixes #7874
How to test
build(...)
call never returns from imagebuilder. I tried to find the root cause, but ultimately it's out-of-scope here.Release Notes
Documentation