Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream imagebuild logs directly from pods #7899

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Jan 28, 2022

Description

Streams log URLs from the imagebuild workspace directly instead via image-builder-mk3, which made it cluster dependent.

Basically

  • old: server -> (cluster-local) image-builder-mk3 -> imgbuild workspace
  • new: server -> imgbuild workspace

Related Issue(s)

Fixes #7874

How to test

Release Notes

none

Documentation

  • /werft with-clean-slate-deployment
  • /werft with-observability

@roboquat roboquat added do-not-merge/work-in-progress release-note-none team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team size/XXL labels Jan 28, 2022
@geropl
Copy link
Member Author

geropl commented Jan 28, 2022

/werft run

👍 started the job as gitpod-build-gpl-7874-imagebuild-logs.9

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #7899 (1129ace) into main (a82a23f) will decrease coverage by 1.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7899      +/-   ##
==========================================
- Coverage   11.46%   10.20%   -1.27%     
==========================================
  Files          20       18       -2     
  Lines        1177     1009     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1039      905     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82a23f...1129ace. Read the comment docs.

@geropl geropl force-pushed the gpl/7874-imagebuild-logs branch from 01b9f84 to ced21ef Compare January 31, 2022 08:59
@geropl geropl force-pushed the gpl/7874-imagebuild-logs branch 5 times, most recently from 351b1ab to 5db1591 Compare January 31, 2022 12:42
@geropl
Copy link
Member Author

geropl commented Jan 31, 2022

/werft run

👍 started the job as gitpod-build-gpl-7874-imagebuild-logs.17

@geropl
Copy link
Member Author

geropl commented Jan 31, 2022

/werft run

👍 started the job as gitpod-build-gpl-7874-imagebuild-logs.18

@geropl geropl requested a review from a team January 31, 2022 15:46
@geropl geropl force-pushed the gpl/7874-imagebuild-logs branch from 5db1591 to 3fd7b84 Compare January 31, 2022 15:48
@geropl geropl marked this pull request as ready for review January 31, 2022 15:50
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

roboquat commented Feb 1, 2022

LGTM label has been added.

Git tree hash: e713670d411534f3e37f15ad31ed52b2b99304c1

@geropl
Copy link
Member Author

geropl commented Feb 1, 2022

/hold

to apply instance changes

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geropl geropl force-pushed the gpl/7874-imagebuild-logs branch from 3fd7b84 to 1b4c753 Compare February 1, 2022 14:23
@roboquat roboquat removed the lgtm label Feb 1, 2022
@geropl geropl force-pushed the gpl/7874-imagebuild-logs branch from 1b4c753 to 1129ace Compare February 1, 2022 15:28
@geropl geropl requested review from csweichel and a team February 1, 2022 15:41
@csweichel
Copy link
Contributor

did not actually try this, but image-builder and API changes look good.

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Feb 2, 2022

LGTM label has been added.

Git tree hash: 5ae979b6ca3262a6e075e23062b58251338adcde

@geropl
Copy link
Member Author

geropl commented Feb 2, 2022

/unhold

@roboquat roboquat merged commit 51568c7 into main Feb 2, 2022
@roboquat roboquat deleted the gpl/7874-imagebuild-logs branch February 2, 2022 16:35
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

roboquat commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, JanKoehnlein, sagor999

Associated issue: #7874

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make imagebuild logs independent of cluster locality
5 participants