-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[messagebus, bridge] Remove messagebus cross-cluster dependency #7523
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7523 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a85ce65
to
f9a33e7
Compare
e83c1f4
to
1f259aa
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #7468 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f259aa
to
0c376d3
Compare
98c5a5e
to
4fac32b
Compare
4fac32b
to
29b17d1
Compare
/hold
Now: don't merge when I'm not prepared to monitor deployment. 🕵️♂️ |
29b17d1
to
3eacd33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM codewise. Let's merge and test it on staging
/unhold |
Description
This PR contains two complementary changes:
gitpod.ws
) and use local exchanges instead (gitpod.ws.local
)ws-manager-bridge
so that bridges that are non-govern
ing:a. still don't write updates to the DB,
b. but do the same derivation of updates,
c. and distributes those over their cluster's local messagebus
Note: This PR can be reviewed commit by commit!
Pain points
This polling and hashing feel quite expensive, especially in scenarios where things go haywire already (a lot of workspaces hanging in preparing). But I see no way around it until we pushed image-builder into workspace clusters (#7845). 🤷 Once that's done we should be able to just delete PreparingUpdateEmulator 🗑️ .
Deployment
This PR is meant to be a drop-in replacement for the current setup, which means:
ToDo:
think about how to properly test this, ideally beforeon stagingPreparingUpdateEmulator
w.r.t. image build logssolved in: Stream imagebuild logs directly from pods #7899Related Issue(s)
Fixes #7468
How to test
cluster-local works as before
cross-cluster
We'll test this on staging as the setup is already there, and an alternative setup would eat too much time at the moment.
Release Notes
Documentation