Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: remove ws-scheduler from config #7878

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

This is now longer part of the application so not required

How to test

Release Notes

NONE

Documentation

This is now longer part of the application so not required
@roboquat roboquat added release-note-none team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team size/XS labels Jan 27, 2022
@mrsimonemms
Copy link
Contributor Author

/assign @gitpod-io/engineering-workspace

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Jan 27, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e9fa8c72f81fb3ea13432e125a09d3b84b31da0

@mrsimonemms
Copy link
Contributor Author

@aledbf now that #7430 has been merged, I think this is a piece that's been left over

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #7878 (0361b8a) into main (fb502be) will decrease coverage by 3.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7878      +/-   ##
=========================================
- Coverage   11.46%   7.77%   -3.70%     
=========================================
  Files          20      31      +11     
  Lines        1177    2187    +1010     
=========================================
+ Hits          135     170      +35     
- Misses       1039    2015     +976     
+ Partials        3       2       -1     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.61% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb502be...0361b8a. Read the comment docs.

@mrsimonemms
Copy link
Contributor Author

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, MrSimonEmms

Associated issue requirement bypassed by: MrSimonEmms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 76332f9 into main Jan 27, 2022
@roboquat roboquat deleted the sje/installer-remove-ws-scheduler branch January 27, 2022 16:38
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production release-note-none size/XS team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants