Remove ws-scheduler #7430

aledbf · 2022-01-04T00:25:59Z

Description

Remove custom ws-scheduler component

How to test

Workspaces should start without issues

Release Notes

Remove ws-scheduler component

codecov · 2022-01-04T00:41:46Z

Codecov Report

Merging #7430 (1f516a3) into main (43198ce) will increase coverage by 18.21%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##             main    #7430       +/-   ##
===========================================
+ Coverage   11.46%   29.68%   +18.21%     
===========================================
  Files          20      117       +97     
  Lines        1177    19290    +18113     
===========================================
+ Hits          135     5727     +5592     
- Misses       1039    13074    +12035     
- Partials        3      489      +486

Flag	Coverage Δ
components-content-service-app	`13.92% <ø> (?)`
components-content-service-lib	`13.92% <ø> (?)`
components-ee-agent-smith-app	`40.05% <ø> (?)`
components-ee-agent-smith-lib	`40.32% <ø> (?)`
components-gitpod-cli-app	`10.20% <ø> (ø)`
components-image-builder-mk3-app	`35.26% <ø> (?)`
components-installation-telemetry-app	`∅ <ø> (?)`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`
components-supervisor-app	`35.41% <ø> (?)`
components-workspacekit-app	`7.19% <ø> (?)`
components-ws-daemon-app	`21.85% <ø> (?)`
components-ws-daemon-lib	`21.85% <ø> (?)`
components-ws-manager-app	`40.74% <100.00%> (?)`
components-ws-proxy-app	`68.32% <ø> (?)`
installer-raw-app	`5.76% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
installer/pkg/components/ws-manager/configmap.go	`30.05% <0.00%> (ø)`
installer/pkg/components/ws-manager/tlssecret.go	`0.00% <ø> (ø)`
components/ws-manager/pkg/manager/create.go	`83.17% <100.00%> (ø)`
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/components/ws-manager/rolebinding.go	`0.00% <0.00%> (ø)`
components/ws-daemon/pkg/resources/controller.go	`31.06% <0.00%> (ø)`
components/workspacekit/cmd/nsenter.go	`25.00% <0.00%> (ø)`
components/supervisor/pkg/supervisor/ssh.go	`0.00% <0.00%> (ø)`
components/ws-daemon/pkg/content/archive.go	`57.95% <0.00%> (ø)`
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43198ce...1f516a3. Read the comment docs.

stale · 2022-01-15T19:43:22Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

aledbf · 2022-01-18T10:27:11Z

/werft run

👍 started the job as gitpod-build-aledbf-scheduler.4

mrsimonemms

/lgtm
/approve

This does raise an interesting question with regards to the Installer - unlike Helm, the Installer doesn't remove Kubernetes objects that are no longer used. What that means is that an installation that's deploying this change will still have their ws-scheduler resources in their cluster.

@csweichel should we work out a way of a deployment removing unused resources when running the kubectl apply -f gitpod.yaml (for the record, I don't have any thoughts on how we might achieve that within the existing Installer workflow)

roboquat · 2022-01-18T15:53:22Z

LGTM label has been added.

Git tree hash: acabba8e62748faa1d2e0b8e65b6f6ca8b4494f1

iQQBot · 2022-01-18T15:55:49Z

/approve

csweichel · 2022-01-18T16:05:31Z

/lgtm /approve

This does raise an interesting question with regards to the Installer - unlike Helm, the Installer doesn't remove Kubernetes objects that are no longer used. What that means is that an installation that's deploying this change will still have their ws-scheduler resources in their cluster.

@csweichel should we work out a way of a deployment removing unused resources when running the kubectl apply -f gitpod.yaml (for the record, I don't have any thoughts on how we might achieve that within the existing Installer workflow)

we'll want to eventually implement the installer apply which would do that based on the configmap with k8s objects that we put in place

csweichel · 2022-01-18T16:05:47Z

/lgtm

aledbf · 2022-01-18T16:06:19Z

/assign @jankeromnes

geropl · 2022-01-18T16:47:47Z

/assign @geropl

@aledbf Awesome that we moved past beyond this... crutch. 🎉 (also: far well 🥲 )

Without looking at the changes in detail (looks like it's a plain removal) I have two questions:

(more out of curiosity, a link to discussion/PRs/doc is fine): How do we solve the pre-scaleup-problem in environments where we do not control the scheduler/cluster configuration? 🤔 (relevant for bigger self-hosted installations)
How do we roll this out? Especially for meta clusters, which currently still have ws-scheduler installed and execute prebuilds/image builds?

aledbf · 2022-01-18T16:52:33Z

How do we solve the pre-scaleup-problem in environments where we do not control the scheduler/cluster configuration?

The idea here is to rely on the standard kubernetes scheduler or use one of the scheduler-plugins. For the majority of the scenarios, the standard scheduler is the right choice.

How do we roll this out?

Since last week, the workspace clusters gen27 are running without ghost and ws-scheduler.
For meta, I suggest we just remove the setting schedulerName from ws-manager configmap and execute a kubectl rollout restart as the first step and run one or two days to compare the behavior.

geropl · 2022-01-18T16:56:21Z

The idea here is to rely on the standard kubernetes scheduler or use one of the scheduler-plugins. For the majority of the scenarios, the standard scheduler is the right choice.

Thx, will read up on this. 🙂

For meta, I suggest we just remove the setting schedulerName from ws-manager configmap and execute a kubectl rollout restart.

@aledbf Alright, that'll work. Will add a notice to next deployment (tomorrow morning).

/lgtm

geropl · 2022-01-18T16:56:58Z

/hold

Holding to ensure we do not merge before tomorrows webapp deployment. Not strictly necessary, but keeps things simple in case sth else goes haywire. Will remove after the deployment went smoothly.

geropl · 2022-01-18T16:57:07Z

/approve no-issue

csweichel · 2022-01-24T19:06:45Z

/lgtm

roboquat · 2022-01-24T19:06:48Z

LGTM label has been added.

Git tree hash: 5507bb3a1677dbfacaa56f64e1e0c5485f98301c

roboquat · 2022-01-24T19:06:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, geropl, iQQBot, MrSimonEmms

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [MrSimonEmms,csweichel,geropl,iQQBot]
~~components/common-go/OWNERS~~ [csweichel]
~~components/ee/ws-scheduler/OWNERS~~ [csweichel]
~~components/gitpod-cli/OWNERS~~ [iQQBot]
~~components/image-builder-bob/OWNERS~~ [csweichel]
~~components/installation-telemetry/OWNERS~~ [MrSimonEmms]
~~components/proxy/OWNERS~~ [geropl]
~~components/ws-daemon/OWNERS~~ [csweichel]
~~components/ws-manager/OWNERS~~ [csweichel]
~~components/ws-manager-api/OWNERS~~ [csweichel]
~~components/ws-proxy/OWNERS~~ [csweichel]
~~installer/OWNERS~~ [MrSimonEmms]
~~installer/pkg/components/ws-manager/OWNERS~~ [csweichel]
~~installer/pkg/components/ws-scheduler/OWNERS~~ [csweichel]
~~operations/observability/mixins/workspace/OWNERS~~ [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

csweichel · 2022-01-24T19:07:57Z

webapp deployment happened - let's do this

/hold cancel

roboquat added release-note do-not-merge/work-in-progress team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team size/XXL labels Jan 4, 2022

aledbf force-pushed the aledbf/scheduler branch from 970eeb8 to 2ebdabe Compare January 4, 2022 00:31

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 15, 2022

aledbf removed the meta: stale This issue/PR is stale and will be closed soon label Jan 15, 2022

aledbf force-pushed the aledbf/scheduler branch from 2b58854 to 0126c9d Compare January 15, 2022 23:24

roboquat added the team: IDE label Jan 15, 2022

aledbf force-pushed the aledbf/scheduler branch from 0126c9d to e77577c Compare January 18, 2022 10:01

roboquat added the team: webapp Issue belongs to the WebApp team label Jan 18, 2022

aledbf changed the title ~~Remove ws-scheduler and custom schedulerName~~ Remove ws-scheduler Jan 18, 2022

aledbf marked this pull request as ready for review January 18, 2022 10:02

roboquat removed the do-not-merge/work-in-progress label Jan 18, 2022

mrsimonemms reviewed Jan 18, 2022

View reviewed changes

roboquat assigned mrsimonemms Jan 18, 2022

roboquat added the lgtm label Jan 18, 2022

roboquat assigned csweichel Jan 18, 2022

roboquat assigned jankeromnes Jan 18, 2022

roboquat assigned geropl Jan 18, 2022

roboquat added the do-not-merge/hold label Jan 18, 2022

roboquat added the approved label Jan 18, 2022

aledbf force-pushed the aledbf/scheduler branch from e77577c to c6fdc8f Compare January 19, 2022 22:46

roboquat removed the lgtm label Jan 19, 2022

Remove ws-scheduler

1f516a3

aledbf force-pushed the aledbf/scheduler branch from c6fdc8f to 1f516a3 Compare January 24, 2022 10:23

roboquat added the lgtm label Jan 24, 2022

roboquat removed the do-not-merge/hold label Jan 24, 2022

roboquat merged commit 82d786e into main Jan 24, 2022

roboquat deleted the aledbf/scheduler branch January 24, 2022 19:08

roboquat added the deployed: workspace Workspace team change is running in production label Jan 25, 2022

mrsimonemms mentioned this pull request Jan 27, 2022

[installer]: remove ws-scheduler from config #7878

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ws-scheduler #7430

Remove ws-scheduler #7430

aledbf commented Jan 4, 2022 •

edited

Loading

codecov bot commented Jan 4, 2022 •

edited

Loading

stale bot commented Jan 15, 2022

aledbf commented Jan 18, 2022 •

edited by werft-gitpod-dev-com bot

Loading

mrsimonemms left a comment

roboquat commented Jan 18, 2022

iQQBot commented Jan 18, 2022

csweichel commented Jan 18, 2022

csweichel commented Jan 18, 2022

aledbf commented Jan 18, 2022

geropl commented Jan 18, 2022

aledbf commented Jan 18, 2022 •

edited

Loading

geropl commented Jan 18, 2022

geropl commented Jan 18, 2022 •

edited

Loading

geropl commented Jan 18, 2022

csweichel commented Jan 24, 2022

roboquat commented Jan 24, 2022

roboquat commented Jan 24, 2022

csweichel commented Jan 24, 2022

Remove ws-scheduler #7430

Remove ws-scheduler #7430

Conversation

aledbf commented Jan 4, 2022 • edited Loading

Description

How to test

Release Notes

codecov bot commented Jan 4, 2022 • edited Loading

Codecov Report

stale bot commented Jan 15, 2022

aledbf commented Jan 18, 2022 • edited by werft-gitpod-dev-com bot Loading

mrsimonemms left a comment

Choose a reason for hiding this comment

roboquat commented Jan 18, 2022

iQQBot commented Jan 18, 2022

csweichel commented Jan 18, 2022

csweichel commented Jan 18, 2022

aledbf commented Jan 18, 2022

geropl commented Jan 18, 2022

aledbf commented Jan 18, 2022 • edited Loading

geropl commented Jan 18, 2022

geropl commented Jan 18, 2022 • edited Loading

geropl commented Jan 18, 2022

csweichel commented Jan 24, 2022

roboquat commented Jan 24, 2022

roboquat commented Jan 24, 2022

csweichel commented Jan 24, 2022

aledbf commented Jan 4, 2022 •

edited

Loading

codecov bot commented Jan 4, 2022 •

edited

Loading

aledbf commented Jan 18, 2022 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Jan 18, 2022 •

edited

Loading

geropl commented Jan 18, 2022 •

edited

Loading