[installer]: put component ownership under webapp/workspace teams #7839
Conversation
roboquat
added
release-note
team: delivery
|
/assign @csweichel |
|
/hold Approval is required from @gitpod-io/engineering-self-hosted to go in but would like @csweichel to give his overview before it's merged in |
Codecov Report
@@ Coverage Diff @@
## main #7839 +/- ##
=========================================
- Coverage 11.46% 7.82% -3.65%
=========================================
Files 20 31 +11
Lines 1177 2173 +996
=========================================
+ Hits 135 170 +35
- Misses 1039 2001 +962
+ Partials 3 2 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/unhold |
| - engineering-workspace | ||
|
|
||
| labels: | ||
| - "team: workspace" |
There was a problem hiding this comment.
nit: new line. And other files
There was a problem hiding this comment.
Ordinarily I'd agree, but this is the case throughout the OWNERS files - in fact, this is copied directly over from them
|
LGTM label has been added. Git tree hash: 7a4d510a8130774cbc9e65c79c7c2ab040b36328
|
|
looks good from workspace perspective |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrSimonEmms, princerachit Associated issue: #7690 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Create a
components-webappandcomponents-workspacepackage to make the Kubernetes objects subject to per-team approval.A couple of observations as to why I did it the way I did:
/pkg/components/workspace/<packages>, but this caused cyclic dependency issues. The use of acomponents-<package>is a way of avoiding this, even though it's arguably a less elegant solution. I'm open to ideas on alternative ways of achieving thiscomponents-workspacepackages are owned by @gitpod-io/engineering-workspace. Thecomponents-webapppackages are owned by different teams, but I have elected to make the folder owned solely by @gitpod-io/engineering-webappRelated Issue(s)
Fixes #7690
How to test
Release Notes
Documentation