Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Make the Kubernetes objects subject to per-team approval #7690

Closed
csweichel opened this issue Jan 19, 2022 · 1 comment · Fixed by #7839
Closed

[installer] Make the Kubernetes objects subject to per-team approval #7690

csweichel opened this issue Jan 19, 2022 · 1 comment · Fixed by #7839
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team

Comments

@csweichel
Copy link
Contributor

When making changes to components in the installer today, one needs the approval of the team which owns that component. That does not hold for the set of objects that make up the environment, e.g.

var MetaObjects = common.CompositeRenderFunc(
contentservice.Objects,
proxy.Objects,
dashboard.Objects,
database.Objects,
ide_proxy.Objects,
imagebuildermk3.Objects,
migrations.Objects,
minio.Objects,
openvsxproxy.Objects,
rabbitmq.Objects,
server.Objects,
wsmanagerbridge.Objects,
)
var WorkspaceObjects = common.CompositeRenderFunc(
agentsmith.Objects,
blobserve.Objects,
registryfacade.Objects,
workspace.Objects,
wsdaemon.Objects,
wsmanager.Objects,
wsproxy.Objects,
wsscheduler.Objects,
)
var FullObjects = common.CompositeRenderFunc(
MetaObjects,
WorkspaceObjects,
)

This has broken things in the past, e.g. #7686

@csweichel csweichel added the team: delivery Issue belongs to the self-hosted team label Jan 19, 2022
@corneliusludmann corneliusludmann added the component: install Terraform installation scripts, helm charts, installer images label Jan 25, 2022
@mrsimonemms mrsimonemms added this to the release/2022.01 milestone Jan 25, 2022
@mrsimonemms
Copy link
Contributor

@mrsimonemms This may slip to 2022.02, but check how difficult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants