Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type in GithubAppPrebuildConfig #7738

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix incorrect type in GithubAppPrebuildConfig #7738

merged 1 commit into from
Jan 21, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Jan 20, 2022

Description

Fix incorrect type in GithubAppPrebuildConfig, this broke opening workspaces in vscode desktop

Related Issue(s)

Fixes #7718
This broke in #7535
cc @svenefftinge

How to test

  1. Open a preview env
  2. Open a repo with addCheck: prevent-merge-on-error in .gitpod.yml e.g. https://github.com/jeanp413/test-gp
  3. Connect to workspace with local vscode desktop stable/insiders should work

Release Notes

NONE

@roboquat roboquat added release-note-none team: webapp Issue belongs to the WebApp team size/XS labels Jan 20, 2022
@jeanp413
Copy link
Member Author

jeanp413 commented Jan 20, 2022

/werft run

👍 started the job as gitpod-build-jp-fix-7718.3

@jeanp413 jeanp413 requested a review from a team January 20, 2022 21:08
@jeanp413
Copy link
Member Author

jeanp413 commented Jan 20, 2022

/werft run

👍 started the job as gitpod-build-jp-fix-7718.4

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #7738 (5d9a815) into main (cbbf4cb) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7738      +/-   ##
==========================================
+ Coverage   10.28%   10.38%   +0.09%     
==========================================
  Files          18       18              
  Lines        1001      992       -9     
==========================================
  Hits          103      103              
+ Misses        897      888       -9     
  Partials        1        1              
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/credential-helper.go 1.34% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a907f9...5d9a815. Read the comment docs.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f87748582619cd8e568e56dcb53e0b3b4f0f68c

@jankeromnes
Copy link
Contributor

Also looks good to me -- thanks for the quick fix!

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot, jankeromnes

Associated issue: #7718

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit e899a4c into main Jan 21, 2022
@roboquat roboquat deleted the jp/fix-7718 branch January 21, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in VS Code on Desktop not working anymore
4 participants