-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect type in GithubAppPrebuildConfig #7738
Conversation
/werft run 👍 started the job as gitpod-build-jp-fix-7718.3 |
/werft run 👍 started the job as gitpod-build-jp-fix-7718.4 |
Codecov Report
@@ Coverage Diff @@
## main #7738 +/- ##
==========================================
+ Coverage 10.28% 10.38% +0.09%
==========================================
Files 18 18
Lines 1001 992 -9
==========================================
Hits 103 103
+ Misses 897 888 -9
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM label has been added. Git tree hash: 3f87748582619cd8e568e56dcb53e0b3b4f0f68c
|
Also looks good to me -- thanks for the quick fix! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iQQBot, jankeromnes Associated issue: #7718 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fix incorrect type in GithubAppPrebuildConfig, this broke opening workspaces in vscode desktop
Related Issue(s)
Fixes #7718
This broke in #7535
cc @svenefftinge
How to test
addCheck: prevent-merge-on-error
in .gitpod.yml e.g. https://github.com/jeanp413/test-gpRelease Notes