Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] allow prevent merge on failed prebuilds #7535

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jan 11, 2022

Introduces an option to make the commit checks pass on the status of the prebuild, i.e. allows to prevent merging a PR when a prebuild failed.

fixes #7518

Release Notes

[GitHub] Optionally prevent merging pull requests when prebuilds fail.

Documentation

https://github.com/gitpod-io/website/pull/1446

@svenefftinge svenefftinge requested a review from a team January 11, 2022 07:33
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #7535 (55ec837) into main (e7b0e0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7535   +/-   ##
=====================================
  Coverage   9.53%   9.53%           
=====================================
  Files         18      18           
  Lines       1080    1080           
=====================================
  Hits         103     103           
  Misses       976     976           
  Partials       1       1           
Flag Coverage Δ
components-gitpod-cli-app 9.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ef34d...55ec837. Read the comment docs.

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Jan 11, 2022

Looking at this now 👀

@JanKoehnlein
Copy link
Contributor

/lgtm

Codewise. Couldn't test it as I was unable to get the GitHub app installed in a preview env (internal conversation).

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d607e1a58bff842c6a18796bdf73bbc9ba074eb2

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 1c3b62d into main Jan 12, 2022
@roboquat roboquat deleted the se/github-app-check-7518 branch January 12, 2022 16:44
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[GitHub App] Optional allow the PR check to fail when prebuild fails
3 participants