Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[installer] Fix registry-facade ClusterRoleBinding name" #7676

Closed
wants to merge 1 commit into from

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 19, 2022

Reverts #7670

@roboquat
Copy link
Contributor

@aledbf: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from aledbf after the PR has been reviewed.

Associated issue: #7670

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member Author

aledbf commented Jan 19, 2022

/werft run

👍 started the job as gitpod-build-revert-7670-aledbf-crvb.1

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #7676 (9de1396) into main (4a33195) will increase coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #7676      +/-   ##
=========================================
+ Coverage   8.69%   10.38%   +1.68%     
=========================================
  Files         33       18      -15     
  Lines       2323      992    -1331     
=========================================
- Hits         202      103      -99     
+ Misses      2117      888    -1229     
+ Partials       4        1       -3     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/ws-manager/unpriviledged-rolebinding.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/tlssecret.go
installer/pkg/common/render.go
components/local-app/pkg/auth/pkce.go
installer/pkg/components/ws-manager/configmap.go
installer/pkg/common/common.go
...staller/pkg/components/ws-manager/networkpolicy.go
installer/pkg/components/ws-manager/rolebinding.go
installer/pkg/common/storage.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a33195...9de1396. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jan 19, 2022

/werft run

👍 started the job as gitpod-build-revert-7670-aledbf-crvb.2

@aledbf aledbf closed this Jan 19, 2022
@aledbf aledbf deleted the revert-7670-aledbf/crvb branch July 4, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants