Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Fix registry-facade ClusterRoleBinding name #7670

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 18, 2022

Description

The ClusterRoleBinding must include the namespace to allow multiple installations

Release Notes

[installer] Fix registry-facade ClusterRoleBinding name

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/XS labels Jan 18, 2022
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e1bf5b4971ca6c051ba3e8cbfe0d4613d05c6b7

@kylos101
Copy link
Contributor

/approve no-issue

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jan 18, 2022

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, kylos101

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #7670 (7f387cd) into main (5cdf2b2) will decrease coverage by 7.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #7670      +/-   ##
=========================================
- Coverage   15.12%   7.88%   -7.25%     
=========================================
  Files          46      31      -15     
  Lines        4468    2155    -2313     
=========================================
- Hits          676     170     -506     
+ Misses       3727    1983    -1744     
+ Partials       65       2      -63     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/resources/limiter.go
components/ws-daemon/pkg/content/hooks.go
components/ws-daemon/pkg/quota/xfs.go
components/ws-daemon/pkg/content/archive.go
components/ws-daemon/pkg/content/initializer.go
components/ws-daemon/pkg/internal/session/store.go
components/local-app/pkg/auth/pkce.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/content/config.go
components/local-app/pkg/auth/auth.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdf2b2...7f387cd. Read the comment docs.

@kylos101 kylos101 mentioned this pull request Jan 18, 2022
1 task
@roboquat roboquat merged commit 4a33195 into main Jan 18, 2022
@roboquat roboquat deleted the aledbf/crvb branch January 18, 2022 22:08
@aledbf aledbf restored the aledbf/crvb branch January 19, 2022 02:03
@aledbf
Copy link
Member Author

aledbf commented Jan 19, 2022

/werft run

👍 started the job as gitpod-build-aledbf-crvb.2

@aledbf aledbf deleted the aledbf/crvb branch January 19, 2022 11:29
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants