Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft to detect system theme in port not found page #7321

Closed
wants to merge 1 commit into from

Conversation

championshuttler
Copy link
Contributor

Fix #7274

@roboquat
Copy link
Contributor

@championshuttler: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign aledbf after the PR has been reviewed.
You can assign the PR to them by writing /assign @aledbf in a comment when ready.

Associated issue: #7274

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat added team: workspace Issue belongs to the Workspace team size/S labels Dec 20, 2021
@championshuttler
Copy link
Contributor Author

idk how to test this code or if this is right, any help would be appreciated thanks

@championshuttler championshuttler changed the title Draft to detect system theme Draft to detect system theme in port not found page Dec 20, 2021
@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021

Hi @championshuttler Thanks for your contribution, and could you please use our PR template? 🙏

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021

idk how to test this code or if this is right, any help would be appreciated thanks

@championshuttler Unfortunately, this page doesn't use react

@championshuttler
Copy link
Contributor Author

championshuttler commented Dec 21, 2021

@championshuttler Unfortunately, this page doesn't use react

Can you suggest me what can i do now thanks

@iQQBot
Copy link
Contributor

iQQBot commented Dec 21, 2021

  1. Need add some css for dark theme
  2. Avoid using the react method and use the dom method directly to get the theme settings

@stale
Copy link

stale bot commented Jan 1, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 1, 2022
@stale stale bot closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make port not found page dark theme aware
3 participants