Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make port not found page dark theme aware #7274

Open
gtsiolis opened this issue Dec 16, 2021 · 3 comments
Open

Make port not found page dark theme aware #7274

gtsiolis opened this issue Dec 16, 2021 · 3 comments
Assignees
@RayAsh37
Labels
component: dashboard feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: feature request New feature or request user experience

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

The product already adapts to dark or system theme for the dashboard (see #6747) and the editor (see #6403).

However, the Port XYZ Not Found page is still using light only theme.

Port XYZ Not Found
Screenshot 2021-12-17 at 12 17 12 AM (2)

Proposal

Let's make Port XYZ Not Found page adapt to system or dark theme aware. 🌔
@championshuttler championshuttler mentioned this issue Dec 20, 2021
Closed
@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 31, 2022
@stale stale bot closed this as completed Jun 19, 2022
@gtsiolis
Copy link
Contributor Author

Although this is minor, reopening and marking as never stale for now.

@gtsiolis gtsiolis reopened this Jun 27, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 27, 2022
@gtsiolis gtsiolis added meta: stale This issue/PR is stale and will be closed soon meta: never-stale This issue can never become stale labels Jun 27, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 27, 2022
@RayAsh37 RayAsh37 mentioned this issue Apr 26, 2023
Closed
14 tasks
@RayAsh37
Copy link
Contributor

@gtsiolis I have tried setting theme according to the current system settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RayAsh37 RayAsh37

Labels
component: dashboard feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: feature request New feature or request user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft to detect system theme in port not found page championshuttler/gitpod
added dark theme
2 participants
@gtsiolis @RayAsh37