Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Change default color theme from Light → System #6747

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Nov 17, 2021

Description

Until today, the default color theme in the dashboard was Light (regardless of your system preference).

However, changing the default to System makes more sense: This will cause Gitpod's theme to remain light, except if you've told your OS that all apps should be dark (in which case Gitpod will now honor that preference by default).

Related Issue(s)

Fixes #6395

How to test

  1. Open the preview environment (the login screen should already match your OS preference for light or dark)
  2. https://jx-default-system-theme.staging.gitpod-dev.com/preferences should have "System" theme pre-selected
  3. If you change your OS color theme preference, the preview theme should automatically respond (without even needing a refresh)

Release Notes

[dashboard] Change default color theme from Light → System

Documentation

/uncc

@AlexTugarev
Copy link
Member

/lgtm

works as advertised, but only for firefox on mac. tried with safari & chrome, but theme changes of the OS were not reflected.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 610ebcbd85ebce4292bede5023a6f160d71ef3d1

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue: #6395

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0ded267 into main Nov 17, 2021
@roboquat roboquat deleted the jx/default-system-theme branch November 17, 2021 15:42
@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 17, 2021

Whoa, it's happening! Thanks @jankeromnes @AlexTugarev! 🌔

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 17, 2021

Many thanks @AlexTugarev! 🚀

but only for firefox on mac. tried with safari & chrome, but theme changes of the OS were not reflected.

Oh oh, forgot to test with Chrome / Safari 😬 will check and possibly open a follow-up issue. Thanks for catching!

@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 17, 2021

FWIW, I could be missing something but seems to work as expected on Chrome, Firefox, and Safari on staging. 🤷
Cc @jankeromnes @AlexTugarev

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change dashboard default theme to system for new users
4 participants