-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Change default color theme from Light → System #6747
Conversation
/lgtm works as advertised, but only for firefox on mac. tried with safari & chrome, but theme changes of the OS were not reflected. |
LGTM label has been added. Git tree hash: 610ebcbd85ebce4292bede5023a6f160d71ef3d1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev Associated issue: #6395 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Whoa, it's happening! Thanks @jankeromnes @AlexTugarev! 🌔 |
Many thanks @AlexTugarev! 🚀
Oh oh, forgot to test with Chrome / Safari 😬 will check and possibly open a follow-up issue. Thanks for catching! |
FWIW, I could be missing something but seems to work as expected on Chrome, Firefox, and Safari on staging. 🤷 |
Description
Until today, the default color theme in the dashboard was Light (regardless of your system preference).
However, changing the default to System makes more sense: This will cause Gitpod's theme to remain light, except if you've told your OS that all apps should be dark (in which case Gitpod will now honor that preference by default).
Related Issue(s)
Fixes #6395
How to test
Release Notes
Documentation
/uncc