[server] Pass selected desktop IDE to ws-manager #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
team: IDE
team: webapp
9 tasks
corneliusludmann
changed the title
|
This PR needs to be rebased to #6364, no? |
corneliusludmann
force-pushed
the
clu/desktop-ide-server
branch
from
de675cd to
b06652b
Compare
|
/cc @AlexTugarev |
|
/werft run 👍 started the job as gitpod-build-clu-desktop-ide-server.2 |
corneliusludmann
force-pushed
the
clu/desktop-ide-server
branch
from
b06652b to
56861a6
Compare
|
Since #6368 is merged now, I rebased this PR so that it does not have commits from other PRs anymore. |
|
looking at it right now... |
corneliusludmann
removed
team: workspace
|
/lgtm code changes look good. |
|
LGTM label has been added. Git tree hash: 9057a03964aef9582a3a7c0af26850da14e6474a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev Associated issue: #6270 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has the parts of the umbrella PR #6270 that change the
serverto choose a desktop IDE.This also includes the following changes in order to compile:See #6270 (comment) for more info.
Release Notes