Add desktop IDE image support in registry-facade and ws-manager

[corneliusludmann]

Description

This PR has the parts of the umbrella PR #6270 that changes registry-facade and ws-manager to support desktop IDE images.

See #6270 (comment) for more info.

Release Notes

NONE

[codecov]

Codecov Report

Merging #6364 (1fc23ff) into main (1d7c6ca) will increase coverage by 21.88%.
The diff coverage is 97.05%.

❗ Current head 1fc23ff differs from pull request most recent head 17967fb. Consider uploading reports for the commit 17967fb to get more accurate results

@@             Coverage Diff             @@
##             main    #6364       +/-   ##
===========================================
+ Coverage   19.04%   40.92%   +21.88%     
===========================================
  Files           2       36       +34     
  Lines         168     7381     +7213     
===========================================
+ Hits           32     3021     +2989     
- Misses        134     4126     +3992     
- Partials        2      234      +232     

Flag	Coverage Δ
components-ee-ws-scheduler-app	63.95% <100.00%> (?)
components-ee-ws-scheduler-lib	64.12% <100.00%> (?)
components-image-builder-mk3-app	34.96% <100.00%> (?)
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-ws-manager-app	39.55% <95.45%> (?)
installer-app	6.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-manager/pkg/manager/status.go	73.77% <93.33%> (ø)
components/ee/ws-scheduler/pkg/scaler/driver.go	54.42% <100.00%> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go	39.48% <100.00%> (ø)
components/ws-manager/pkg/manager/create.go	79.84% <100.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/ws-manager/pkg/manager/manager.go	25.10% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go	0.00% <0.00%> (ø)
components/ee/ws-scheduler/pkg/scaler/time.go	66.66% <0.00%> (ø)
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7c6ca...17967fb. Read the comment docs.

[csweichel]

Thank you very much for splitting this out. I'm somewhat surprised to see the change in this way, considering the original draft.

How much effort would it be to align this with the original design?

[csweichel]

Thank you for making that change.

We're not yet setting DeprecatedIdeImage when returning a WorkspaceSpec, that's backwards incompatible.

The remainder of changes could be put in place in a follow up PR.

[corneliusludmann]

@csweichel It's done.

[csweichel]

Awesome. Thank you for making those changes.

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: dc4e900431f89b0442ce19bc69f1fce73ba40780

[geropl]

server changes LGTM

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, geropl

Associated issue: #6270

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csweichel,geropl]
• components/ee/ws-scheduler/OWNERS [csweichel]
• components/registry-facade/OWNERS [csweichel]
• components/registry-facade-api/OWNERS [csweichel]
• components/server/OWNERS [geropl]
• components/ws-manager/OWNERS [csweichel]
• components/ws-manager-api/OWNERS [csweichel]
• components/ws-proxy/OWNERS [csweichel]
• dev/loadgen/OWNERS [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment