[ws-manager] Introduce stoppedByRequest condition #6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6218 +/- ##
==========================================
+ Coverage 33.96% 39.37% +5.40%
==========================================
Files 130 13 -117
Lines 22323 3779 -18544
==========================================
- Hits 7583 1488 -6095
+ Misses 14059 2168 -11891
+ Partials 681 123 -558
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
LGTM label has been added. Git tree hash: be58609f12e98e4acfd706514fd430a372a1d15e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf Associated issue: #6213 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the stopping behaviour of ws-manager so that when
StopWorkspaceis called we first mark the workspace with agitpod.io/stoppedByRequestannotation which contains the desired termination grace period. This annotation also backs a newstoppedByRequestannotation on the workspace status. This condition can be used to determine if the workspace was stopped by explicit request, e.g. to signal prebuild cancelation.Related Issue(s)
Fixes #6213
How to test
gpctl workspaces subscribe --output-template '{{ .Id }} {{ .Phase }} {{ .Conditions }}'stoppedByRequestannotation is setRelease Notes