Add new workspace condition "stoppedByRequest" #6213
Labels
component: ws-manager
groundwork: awaiting deployment
team: workspace
Issue belongs to the Workspace team
type: feature request
New feature or request
Bug description
When we call
stopWorkspace
with aStopWorkspaceRequest
on some workspace, the stopped workspace should come back to the bridge with a new type of condition attached: for example calledconditions.stoppedByRequest
(in addition to the existing conditionstimeout
,failed
andheadlessTaskFailed
).This would allow cancelling prebuilds (because when a
StopWorkspaceRequest
is called on a prebuild a.k.a. headless workspace, we know that this is a manual cancellation, as the prebuild workspace wasn't left to run until completion or timeout).This would help unblock the cancellable prebuilds PR: #5865 where we currently:
prebuild.state = 'aborted'
immediately from theserver
, which seems to work on the surface, but is risky (becauseprebuild.state
could get modified again by the bridge later when the workspace eventually stops)stoppedByRequest
condition is implemented, we'd be able to look out for that on prebuild workspaces in the bridge and set the correctprebuild.state
.Steps to reproduce
N/A
Workspace affected
No response
Expected behavior
No response
Example repository
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: