Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitpod-protocol] Adjust typescript GRPC options #6166

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 11, 2021

Description

After #6148 we need to adjust the typescript side of GRPC settings to avoid errors related to frequent pings

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","serviceContext":{"service":"ws-manager-bridge","version":"<ts-not-set>"},"component":"ws-manager-bridge","severity":"ERROR","time":"2021-10-11T23:35:42.397Z","environment":"devstaging","message":"Connection to dns:///ws-manager:8080 at 10.100.8.159:8080 rejected by server because of excess pings. Increasing ping interval to 10000 ms","loggedViaConsole":true}

How to test

Check ws-manager-bridge log. There should not be any reference to rejected by server because of excess pings

Release Notes

[gitpod-protocol] Adjust typescript GRPC options

@aledbf
Copy link
Member Author

aledbf commented Oct 12, 2021

/werft run

👍 started the job as gitpod-build-aledbf-grpcts.1

@aledbf
Copy link
Member Author

aledbf commented Oct 12, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Oct 12, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1be3ca946c2a9c0c0280b9fd4b2ddd733bce8082

@csweichel
Copy link
Contributor

/assign @laushinka

@csweichel
Copy link
Contributor

/assign @geropl @JanKoehnlein

@JanKoehnlein
Copy link
Contributor

/lgtm

@geropl geropl self-requested a review October 13, 2021 07:18
@geropl
Copy link
Member

geropl commented Oct 13, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, geropl, JanKoehnlein

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4425adc into main Oct 13, 2021
@roboquat roboquat deleted the aledbf/grpcts branch October 13, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants