Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common-go] Adjust log level and ping keepalive interval #6148

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 11, 2021

Description

Switch from info level to debug. The goal of this change is to reduce the verbosity of GRPC logs (mostly related to the setup of connections). Also, change the default ping interval to 10s (valid min value)

From grpc docs // If set below 10s, a minimum value of 10s will be used instead.

Release Notes

NONE

@aledbf
Copy link
Member Author

aledbf commented Oct 11, 2021

/approve no-issue
/assign @csweichel

@aledbf
Copy link
Member Author

aledbf commented Oct 11, 2021

Example of the grpc messages:

{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] parsed scheme: \"\"","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] scheme \"\" not registered, fallback to default scheme","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] ccResolverWrapper: sending update to cc: {[{ws-manager:8080  \u003cnil\u003e 0 \u003cnil\u003e}] \u003cnil\u003e \u003cnil\u003e}","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] ClientConn switching balancer to \"pick_first\"","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] Channel switches to new LB policy \"pick_first\"","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] Subchannel Connectivity change to CONNECTING","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] Subchannel picks a new address \"ws-manager:8080\" to connect","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] Channel Connectivity change to CONNECTING","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] Subchannel Connectivity change to READY","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}
{"component":"grpc","level":"info","message":"INFO: 2021/10/11 11:42:30 [core] Channel Connectivity change to READY","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"INFO","time":"2021-10-11T11:42:30Z"}

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #6148 (85ceeb9) into main (3743533) will increase coverage by 15.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6148       +/-   ##
===========================================
+ Coverage   19.04%   34.51%   +15.46%     
===========================================
  Files           2      116      +114     
  Lines         168    21401    +21233     
===========================================
+ Hits           32     7386     +7354     
- Misses        134    13345    +13211     
- Partials        2      670      +668     
Flag Coverage Δ
components-blobserve-app 28.57% <ø> (?)
components-common-go-lib 36.89% <ø> (?)
components-content-service-api-go-lib ∅ <ø> (?)
components-content-service-app 14.48% <ø> (?)
components-content-service-lib 14.48% <ø> (?)
components-ee-agent-smith-app 25.52% <ø> (?)
components-ee-kedge-app 45.48% <ø> (?)
components-ee-ws-scheduler-app 62.99% <ø> (?)
components-image-builder-api-go-lib ∅ <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-bob-app ∅ <ø> (?)
components-image-builder-mk3-app 34.46% <ø> (?)
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-openvsx-proxy-app 46.22% <ø> (?)
components-registry-facade-app 11.63% <ø> (?)
components-registry-facade-lib 11.63% <ø> (?)
components-service-waiter-app ∅ <ø> (?)
components-supervisor-app 38.05% <ø> (?)
components-workspacekit-app 7.09% <ø> (?)
components-ws-daemon-api-go-lib ∅ <ø> (?)
components-ws-daemon-app 22.11% <ø> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)
components-ws-manager-api-go-lib ∅ <ø> (?)
components-ws-manager-app 39.26% <ø> (?)
components-ws-proxy-app 68.89% <ø> (?)
dev-loadgen-app ∅ <ø> (?)
dev-poolkeeper-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-manager/pkg/manager/create.go 79.68% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/openvsx-proxy/pkg/modifyresponse.go 72.52% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/blobserve/pkg/blobserve/blobserve.go 8.17% <0.00%> (ø)
...ponents/ee/ws-scheduler/pkg/scheduler/scheduler.go 57.73% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3743533...85ceeb9. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Oct 11, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9b2a3ae3c07d41dbfabe404ab3fedaa32739df06

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 7dabb61 into main Oct 11, 2021
@roboquat roboquat deleted the aledbf/grpcping branch October 11, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants