-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common-go] Adjust log level and ping keepalive interval #6148
Conversation
/approve no-issue |
Example of the grpc messages:
|
Codecov Report
@@ Coverage Diff @@
## main #6148 +/- ##
===========================================
+ Coverage 19.04% 34.51% +15.46%
===========================================
Files 2 116 +114
Lines 168 21401 +21233
===========================================
+ Hits 32 7386 +7354
- Misses 134 13345 +13211
- Partials 2 670 +668
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
LGTM label has been added. Git tree hash: 9b2a3ae3c07d41dbfabe404ab3fedaa32739df06
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel Associated issue requirement bypassed by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Switch from info level to debug. The goal of this change is to reduce the verbosity of GRPC logs (mostly related to the setup of connections). Also, change the default ping interval to 10s (valid min value)
From grpc docs
// If set below 10s, a minimum value of 10s will be used instead.
Release Notes