Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github projects] fix collection of accessible repos #6146

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Oct 11, 2021

Follow-up to #6042

[Projects] Fix collection of accessible GitHub repos

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 11, 2021

Many thanks!

But strangely, when I click on Authorize, I get the following error in the pop-up:

Error: error:0909006C:PEM routines:get_name:no start line
Stack: Error: error:0909006C:PEM routines:get_name:no start line
    at Sign.sign (internal/crypto/sig.js:103:29)
    at Object.sign (/app/node_modules/jsonwebtoken/node_modules/jwa/index.js:152:45)
    at Object.jwsSign [as sign] (/app/node_modules/jsonwebtoken/node_modules/jws/lib/sign-stream.js:32:24)
    at Object.module.exports [as sign] (/app/node_modules/jsonwebtoken/sign.js:204:16)
    at getToken (/app/node_modules/universal-github-app-jwt/dist-node/index.js:13:23)
    at Object.githubAppJwt (/app/node_modules/universal-github-app-jwt/dist-node/index.js:35:23)
    at getAppAuthentication (/app/node_modules/@octokit/auth-app/dist-node/index.js:109:57)
    at hook (/app/node_modules/@octokit/auth-app/dist-node/index.js:388:15)
    at Job.doExecute (/app/node_modules/bottleneck/light.js:405:106)
    at Timeout._onTimeout (/app/node_modules/bottleneck/light.js:1202:23)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)
Screenshot 2021-10-11 at 15 00 03 Screenshot 2021-10-11 at 14 59 52

@AlexTugarev
Copy link
Member Author

@jankeromnes, please try again, it was in the midst of the setup.

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the very quick fix! Code looks good and I can confirm that selecting GitHub repos works again.

Couldn't confirm the fix to #5926 but let's do that on staging (not really related to this PR).

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8050e45393f5eb6f20ea3ee35ce05f3f35c37df4

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #6042

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4750a3f into main Oct 11, 2021
@roboquat roboquat deleted the at/fixup-5926 branch October 11, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants