Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projects] paginate listReposAccessibleToInstallation call #6042

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

AlexTugarev
Copy link
Member

Description

Fetch more repos per installation.

Related Issue(s)

Fixes #5926

How to test

Try to select repos for GH App installations on orgs with more than 100 repos.

Release Notes

[Teams & Projects] Removes 100 repos limitation.

@roboquat roboquat requested a review from JanKoehnlein October 5, 2021 10:11
@AlexTugarev AlexTugarev requested review from jankeromnes and JanKoehnlein and removed request for JanKoehnlein October 5, 2021 10:11
@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

What? How is this already 3 days old and I haven't noticed it 🤦

Many thanks @AlexTugarev for this really cool fix! Looking forward to test it:

/werft run

👍 started the job as gitpod-build-alex-impossible-to-add-a-project-5926.3

@AlexTugarev
Copy link
Member Author

@jankeromnes, I thought it would be because of the GH App integration that no one wants to verify this ;-)

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

In my defense, I received the email just a few minutes ago 🙄

Screenshot 2021-10-08 at 09 43 00

Same thing for the Toast:

Screenshot 2021-10-08 at 09 45 22

I blame GitHub for the delayed event push 😂

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

Will now hook up my GitHub App and review this excellent PR 👍

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

Namespace is gone again 🙄

/werft run

👍 started the job as gitpod-build-alex-impossible-to-add-a-project-5926.4

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

GitHub App connected ✅

@jankeromnes
Copy link
Contributor

jankeromnes commented Oct 8, 2021

Okay, the GitHub App setup doesn't work and is getting a bit tedious.

New plan: Merge this, test on staging, revert if it doesn't work. 🤠

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, looks good to me! Let's launch this 🚀

@roboquat roboquat merged commit 6ec3b5f into main Oct 8, 2021
@roboquat roboquat deleted the alex/impossible-to-add-a-project-5926 branch October 8, 2021 14:49
@roboquat
Copy link
Contributor

roboquat commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #5926

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to add a project (repository list capped at 100)
3 participants