Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: apply type fixes to the installer components #6020

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Oct 4, 2021

Description

Fixed incorrectly defined types in the installer components.

Related Issue(s)

Builds upon #5622

How to test

Release Notes

Fixed incorrectly defined types in the installer components

These have types that were incorrectly applied
@roboquat roboquat requested a review from AlexTugarev October 4, 2021 16:35
@roboquat roboquat added the size/M label Oct 4, 2021
@mrsimonemms mrsimonemms requested review from csweichel and removed request for AlexTugarev October 4, 2021 16:45
@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Oct 5, 2021

LGTM label has been added.

Git tree hash: 08f317af8ebffca151245afa4da1048e289c14dc

@roboquat
Copy link
Contributor

roboquat commented Oct 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5622

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b9d9628 into main Oct 5, 2021
@roboquat roboquat deleted the sje/installer-bugfixes branch October 5, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants