[installer]: Gitpod Installer #5622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer
branch
from
2d2138e to
7b64db0
Compare
aledbf
reviewed
Sep 10, 2021
mrsimonemms
force-pushed
the
sje/installer
branch
from
95fe743 to
4a2838b
Compare
mrsimonemms
force-pushed
the
sje/installer
branch
9 times, most recently
from
5342f26 to
2fd1f50
Compare
mrsimonemms
force-pushed
the
sje/installer
branch
8 times, most recently
from
fc83d93 to
0e90f89
Compare
mrsimonemms
force-pushed
the
sje/installer
branch
3 times, most recently
from
8c3d5ec to
bf54c59
Compare
mrsimonemms
force-pushed
the
sje/installer
branch
2 times, most recently
from
ff6392c to
e552c92
Compare
mrsimonemms
force-pushed
the
sje/installer
branch
from
3f0a809 to
65e4f52
Compare
csweichel
reviewed
Oct 1, 2021
| @@ -308,7 +308,6 @@ function makeLogItem(severity: GoogleLogSeverity, context: LogContext | undefine | |||
| severity, | |||
| time: new Date().toISOString(), | |||
| environment: process.env.KUBE_STAGE, | |||
| region: process.env.GITPOD_REGION, | |||
There was a problem hiding this comment.
For future reviewers: we don't need to log the region out because that's added by the log collection infrastructure (e.g. Stackdriver)
mrsimonemms
commented
Oct 1, 2021
csweichel
reviewed
Oct 1, 2021
added 9 commits
October 1, 2021 15:50
This allows the Config to be exposed for the installer
This commit of the installer contains the converted Helm charts for the main Gitpod application (in an unstable state)
mrsimonemms
force-pushed
the
sje/installer
branch
from
65e4f52 to
77965da
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 92461a7b9562657eaacbd665f243ce3726c0869d
|
|
/approve no-issue |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel, JanKoehnlein Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first pass of the Gitpod Installer. This should be considered the broad scaffolding for the CLI rather than the finished article. It needs moving into the
mainbranch so that development can be spread across the team rather than just by one individual.This also exposes config structs for various components. This is so the ConfigMaps in the Installer can use the structs to generate the JSON.
Related Issue(s)
n/a
How to test
The installer should be considered to be in an unstable state. This is the foundation for future work.
Release Notes
Took the liberty to change the release notes. Original comment was "Components have had their
ServiceConfigexposed as a public struct, so they can be consumed in ConfigMaps in the Installer. This is the first commit of the Installer and should be considered unstable."