-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chart] Fix default log level #5796
Conversation
/approve no-issue |
/assign @csweichel |
/werft run 👍 started the job as gitpod-build-aledbf-chartlog.3 |
/hold |
Codecov Report
@@ Coverage Diff @@
## main #5796 +/- ##
==========================================
- Coverage 31.97% 22.11% -9.86%
==========================================
Files 72 11 -61
Lines 14979 1967 -13012
==========================================
- Hits 4789 435 -4354
+ Misses 9765 1474 -8291
+ Partials 425 58 -367
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
b128661
to
0ae184e
Compare
/werft run 👍 started the job as gitpod-build-aledbf-chartlog.10 |
0ae184e
to
5fb8da8
Compare
/werft run 👍 started the job as gitpod-build-aledbf-chartlog.12 |
/werft run 👍 started the job as gitpod-build-aledbf-chartlog.13 |
c46f237
to
196d626
Compare
/hold cancel |
/werft run 👍 started the job as gitpod-build-aledbf-chartlog.16 |
This change breaks the JSON logging for ws-daemon, which would lead to a misinterpretation of all log messages as ERROR. |
196d626
to
9f52055
Compare
9f52055
to
33deaf9
Compare
33deaf9
to
4d79b91
Compare
Please review/try again |
With #5789 merged, this is the output of
|
4d79b91
to
d125319
Compare
/lgtm |
LGTM label has been added. Git tree hash: b20cae8c2eb10ced14cef3b7c2b11aba9ff2792a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel Associated issue requirement bypassed by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The invocation to the template was missing the context (
.
)Also introduces two different flags for cli binaries, one for
verbose
logs and a different one to setjson-log
output format.Related Issue(s)
Fixes #
How to test
Release Notes