Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Reduce messages log level #5789

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[ws-daemon] Reduce messages log level #5789

merged 1 commit into from
Sep 22, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 21, 2021

Description

Continue cleanup of log messages and levels.

Release Notes

NONE

/approve no-issue

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #5789 (a982271) into main (1a91123) will increase coverage by 13.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5789       +/-   ##
===========================================
+ Coverage   19.04%   32.18%   +13.13%     
===========================================
  Files           2       70       +68     
  Lines         168    14795    +14627     
===========================================
+ Hits           32     4762     +4730     
- Misses        134     9608     +9474     
- Partials        2      425      +423     
Flag Coverage Δ
components-content-service-app 14.52% <0.00%> (?)
components-content-service-lib 14.52% <0.00%> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-mk3-app 6.55% <ø> (?)
components-local-app-app-linux ?
components-local-app-app-windows ?
components-supervisor-app 37.71% <ø> (?)
components-ws-daemon-app 22.30% <0.00%> (?)
components-ws-manager-app 39.12% <ø> (?)
components-ws-proxy-app 67.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/content-service/pkg/initializer/git.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/ws-manager/pkg/manager/manager_ee.go 0.00% <0.00%> (ø)
...s/content-service/pkg/service/workspace-service.go 0.00% <0.00%> (ø)
components/content-service/pkg/git/porcelain.go 91.89% <0.00%> (ø)
components/content-service/pkg/storage/gcloud.go 3.11% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 77.02% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a91123...a982271. Read the comment docs.

@aledbf aledbf changed the title [ws-daemon] Increase messages log level [ws-daemon] Reduce messages log level Sep 21, 2021
@roboquat roboquat added size/S and removed size/XS labels Sep 21, 2021
@aledbf
Copy link
Member Author

aledbf commented Sep 21, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 22, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6861b9f04789a4da8f25e217916490e0e935a7a9

@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 88e4f7b into main Sep 22, 2021
@roboquat roboquat deleted the aledbf/msgf branch September 22, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants