-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Introduce /debug/logging #5697
Conversation
20ac450
to
7015936
Compare
Can't we just change the LOG_LEVEL on the deployment? Having an endpoint that mutates the state of one server instance (which one?) seems unnecessary, because restarts shouldn't be a problem with servers. |
Sadly restarts are a problem with Also, I don't feel that this endpoint adds a lot of complexity. And if shifts the whole debate around logging from "reduce amount of logging" to "improve quality of logging" (bc of the argument "zero cost loglevel switch"), which I really really like. Furthermore, we should re-use |
7015936
to
c9d3a4e
Compare
That is not possible in Kubernetes. Any update to Deployments or Daemonsets updates all the pods and also implies reconnections due to the replacement of pods. |
/approve |
@geropl thank you for working on this ❤️ |
/approve |
c9d3a4e
to
6ab6375
Compare
6ab6375
to
aad8538
Compare
The last force-pushes were conflict resolutions. |
/lgtm |
LGTM label has been added. Git tree hash: 5bb286baa012e9ad6135b02c168f73bf7a6a0b2f
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: aledbf Associated issue: #5551 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Introduces an endpoint for changing log levels at runtime, similar to the one introduced here.
Currently this is server-only.
DebugApp
can and should easily be moved to acommon-ts
package, but did not want to make this part of this PR.Related Issue(s)
Context: #5551
How to test
curl localhost:6060/debug/logging -d '{"level":"info"}'
Release Notes