Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common-log] Enable change of log level at runtime #4433

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 8, 2021

Allow the change of log level at runtime using the pprof port with a new endpoint.

Using port-forward:

Get current level
curl localhost:6060/debug/logging

Change level
curl localhost:6060/debug/logging -d '{"level":"info"}'

default value is trace (current value)

Also configures containerd log (logrus) with gitpod-io log settings

@aledbf aledbf force-pushed the aledbf/dynamiclevel branch 5 times, most recently from 9d75b0d to 53a25c0 Compare June 10, 2021 17:24
@aledbf aledbf requested a review from csweichel June 10, 2021 17:33
@aledbf aledbf force-pushed the aledbf/dynamiclevel branch 2 times, most recently from 5654da2 to bd69abc Compare June 10, 2021 17:44
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM

@aledbf aledbf force-pushed the aledbf/dynamiclevel branch 14 times, most recently from c360a50 to c36bcb5 Compare June 10, 2021 22:36
@aledbf aledbf requested a review from csweichel June 10, 2021 22:57
@aledbf aledbf marked this pull request as ready for review June 10, 2021 22:57
@aledbf
Copy link
Member Author

aledbf commented Jun 11, 2021

/werft run

👍 started the job as gitpod-build-aledbf-dynamiclevel.29

@aledbf
Copy link
Member Author

aledbf commented Jun 11, 2021

/werft run

👍 started the job as gitpod-build-aledbf-dynamiclevel.30

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aledbf aledbf force-pushed the aledbf/dynamiclevel branch from c36bcb5 to 831f242 Compare June 15, 2021 13:30
@aledbf aledbf force-pushed the aledbf/dynamiclevel branch from 831f242 to dd22e2a Compare June 15, 2021 13:46
@aledbf
Copy link
Member Author

aledbf commented Jun 15, 2021

/werft run

👍 started the job as gitpod-build-aledbf-dynamiclevel.33

@aledbf aledbf merged commit 15fbc9b into main Jun 15, 2021
@aledbf aledbf deleted the aledbf/dynamiclevel branch June 15, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants