Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspacekit] Establish IWS conn for proc mounts #5407

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

csweichel
Copy link
Contributor

This PR fixes a bug introduced in #5299 where we'd use a closed client to affect proc and sysfs mounts.

fixes #5171

How to test

cd test
go test -v -run TestRunDocker ./...

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #5407 (dc15065) into main (8aab84e) will increase coverage by 7.22%.
The diff coverage is 0.00%.

❗ Current head dc15065 differs from pull request most recent head c01e080. Consider uploading reports for the commit c01e080 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           main   #5407      +/-   ##
=======================================
+ Coverage      0   7.22%   +7.22%     
=======================================
  Files         0       3       +3     
  Lines         0     609     +609     
=======================================
+ Hits          0      44      +44     
- Misses        0     562     +562     
- Partials      0       3       +3     
Flag Coverage Δ
components-workspacekit-app 7.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/workspacekit/cmd/rings.go 7.10% <0.00%> (ø)
components/workspacekit/cmd/lift.go 18.18% <0.00%> (ø)
components/workspacekit/cmd/root.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aab84e...c01e080. Read the comment docs.

@roboquat roboquat added size/L and removed size/M labels Aug 27, 2021
@csweichel csweichel marked this pull request as ready for review August 27, 2021 09:41
@aledbf
Copy link
Member

aledbf commented Aug 27, 2021

/approve
/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 540039a8c369cd921a6a3e8dc2a59f4a06caba3f

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #5171

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 92cb2c7 into main Aug 27, 2021
@roboquat roboquat deleted the cw/fix-5171 branch August 27, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting docker containers failing with "mount through procfd: operation not permitted"
3 participants