Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspacekit] Refactor ws-daemon grpc client connection #5299

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 20, 2021

Change the behavior from one permanent connection to the IWS socket to multiple connections when needed.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #5299 (c17b723) into main (a1da634) will decrease coverage by 24.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #5299       +/-   ##
==========================================
- Coverage   31.77%   7.17%   -24.60%     
==========================================
  Files          24       3       -21     
  Lines        5697     613     -5084     
==========================================
- Hits         1810      44     -1766     
+ Misses       3713     566     -3147     
+ Partials      174       3      -171     
Flag Coverage Δ
components-workspacekit-app 7.17% <0.00%> (?)
components-ws-daemon-app ?
components-ws-manager-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/workspacekit/cmd/rings.go 7.05% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go
...-manager/pkg/manager/internal/workpool/workpool.go
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go
components/ws-manager/pkg/manager/config.go
components/ws-manager/pkg/manager/status.go
components/ws-manager/pkg/manager/manager_ee.go
components/ws-daemon/pkg/quota/size.go
...omponents/ws-manager/pkg/manager/pod_controller.go
components/ws-daemon/pkg/content/archive.go
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1da634...c17b723. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Aug 24, 2021

/assign @csweichel

@csweichel csweichel marked this pull request as ready for review August 25, 2021 14:10
@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2021

testing

/hold

@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2021

/hold cancel

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 25, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8bae252de88a9eb2f4fbf1cddf324941989a5af3

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants