[ws-daemon] Check for workspace state

[aledbf]

Fixes

{"containerID":"XXXXXX","instanceId":"XXXXXX","level":"debug","message":"resource controller shutting down","serviceContext":{"service":"ws-daemon","version":""},"severity":"DEBUG","time":"2021-08-16T19:49:44Z","userId":"","workspaceId":"XXXXXX"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1c21060]

goroutine 1 [running]:
github.com/gitpod-io/gitpod/ws-daemon/pkg/dispatch.(*Dispatch).Close(0xc0002184d0, 0x0, 0x0)
	github.com/gitpod-io/gitpod/ws-daemon/pkg/dispatch/dispatch.go:152 +0x100
github.com/gitpod-io/gitpod/ws-daemon/pkg/daemon.(*Daemon).Stop(0xc00043edc0, 0x0, 0xc000d24eb8)
	github.com/gitpod-io/gitpod/ws-daemon/pkg/daemon/daemon.go:185 +0x39
github.com/gitpod-io/gitpod/ws-daemon/cmd.glob..func6(0x32cc8a0, 0xc000487410, 0x0, 0x3)
	github.com/gitpod-io/gitpod/ws-daemon/cmd/run.go:123 +0x12e5
github.com/spf13/cobra.(*Command).execute(0x32cc8a0, 0xc0004873e0, 0x3, 0x3, 0x32cc8a0, 0xc0004873e0)
	github.com/spf13/cobra@v1.1.3/command.go:856 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0x32cc620, 0x9, 0x0, 0x0)
	github.com/spf13/cobra@v1.1.3/command.go:960 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.1.3/command.go:897
github.com/gitpod-io/gitpod/ws-daemon/cmd.Execute()
	github.com/gitpod-io/gitpod/ws-daemon/cmd/root.go:49 +0x91
main.main()
	github.com/gitpod-io/gitpod/ws-daemon/main.go:15 +0x25

[aledbf]

/assign @geropl

[geropl]

LGTM

[roboquat]

LGTM label has been added.

Git tree hash: 3fd295de7ac14cb0d358707777d78462b4e6f681

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: geropl

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/ws-daemon/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[geropl]

Looks like we need a rebase+redeploy.

[svenefftinge]

/werft run

👍 started the job as gitpod-build-aledbf-check.1

[codecov]

Codecov Report

Merging #5229 (551e6d4) into main (6f15a43) will decrease coverage by 11.50%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #5229       +/-   ##
===========================================
- Coverage   34.56%   23.05%   -11.51%     
===========================================
  Files          18       11        -7     
  Lines        4534     1926     -2608     
===========================================
- Hits         1567      444     -1123     
+ Misses       2829     1423     -1406     
+ Partials      138       59       -79     

Flag	Coverage Δ
components-ee-agent-smith-app	?
components-local-app-app-darwin	?
components-local-app-app-linux	?
components-local-app-app-windows	?
components-ws-daemon-app	23.05% <ø> (?)
components-ws-manager-app	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-manager/pkg/manager/status.go
components/ee/agent-smith/pkg/agent/egress.go
...omponents/ee/agent-smith/pkg/signature/sinature.go
components/ws-manager/pkg/manager/annotations.go
components/ee/agent-smith/pkg/agent/agent.go
components/ee/agent-smith/pkg/agent/actions.go
...-manager/pkg/manager/internal/workpool/workpool.go
components/ws-manager/pkg/manager/create.go
components/ws-manager/pkg/manager/metrics.go
components/ee/agent-smith/pkg/agent/metrics.go
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f165a...551e6d4. Read the comment docs.