Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault in ws-daemon #5244

Closed
meysholdt opened this issue Aug 17, 2021 · 2 comments
Closed

Segfault in ws-daemon #5244

meysholdt opened this issue Aug 17, 2021 · 2 comments
Assignees

Comments

@meysholdt
Copy link
Member

Spottet twice in prod (here and here) after today's deployment:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1c21260]

goroutine 1 [running]:
github.com/gitpod-io/gitpod/ws-daemon/pkg/dispatch.(*Dispatch).Close(0xc0002d8310, 0x0, 0x0)
	github.com/gitpod-io/gitpod/ws-daemon/pkg/dispatch/dispatch.go:152 +0x100
github.com/gitpod-io/gitpod/ws-daemon/pkg/daemon.(*Daemon).Stop(0xc000532840, 0x0, 0xc0008f8eb8)
	github.com/gitpod-io/gitpod/ws-daemon/pkg/daemon/daemon.go:178 +0x39

The call stack looks like the one from #5229
Container-version of ws-daemon: commit-2e90d32ba9ece42b8f56d1bb298c3ba53b4d2f99.

@JanKoehnlein
Copy link
Contributor

Line numbers are not matching anything sensible in this commit. To me it looks like the log is from a state before that the commit fixed.

@aledbf
Copy link
Member

aledbf commented Aug 19, 2021

Closing. Fixed in #5229

@aledbf aledbf closed this as completed Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants