[dashboard]: only display delete button if not preparing

[mrsimonemms]

Proposed fix for #4173

[roboquat]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign svenefftinge after the PR has been reviewed.
You can assign the PR to them by writing /assign @svenefftinge in a comment when ready.

Associated issue: #4173

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• components/dashboard/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gtsiolis]

Looking at this now! 👀

[gtsiolis]

Lunch happened but I'm back! 🍝

Changes look good, @mrsimonemms!

Ideally, we could allow users to click the delete action and handle all the necessary checks on the backstage even if that's moving the to-be-deleted entry to outside the active workspaces list, as described in option 🅱️ in #4173 (comment). 🌤️

However, I understand there's a technical limitation to do this (#4173 (comment)) so removing the delete option sounds like a good MVC (minimum viable change) especially since this removal is visible at rare times as the user usually switches context to starting a workspace (loading screen) away from the dashboard workspaces list. ✔️

I've added one small nitpick issue about borders but could be fine to skip this, too. Let me know what you think.

[gtsiolis]

thought: Sounds safe to use a similar if statement here as above options.

[mrsimonemms]

/werft run

👍 started the job as gitpod-build-sje-cannot-delete-ws.3

[mrsimonemms]

/werft run

👍 started the job as gitpod-build-sje-cannot-delete-ws.7

[gtsiolis]

issue: @mrsimonemms For some reason I cannot creaste any new workspace, getting the following two errors:

cannot pull image: rpc error: code = Unknown desc = failed to pull and unpack image "reg.sje-cannot-delete-ws.staging.gitpod-dev.com:30474/remote/d0b360df-d75f-496a-a3ef-1b8a19cee9bb:latest": failed to resolve reference "reg.sje-cannot-delete-ws.staging.gitpod-dev.com:30474/remote/d0b360df-d75f-496a-a3ef-1b8a19cee9bb:latest": failed to do request: Head https://reg.sje-cannot-delete-ws.staging.gitpod-dev.com:30474/v2/remote/d0b360df-d75f-496a-a3ef-1b8a19cee9bb/manifests/latest: dial tcp 127.0.0.1:30474: connect: connection refused

cannot pull image: Back-off pulling image "reg.sje-cannot-delete-ws.staging.gitpod-dev.com:30474/remote/bcce5a7d-da3a-431d-8ebc-0b83386bace9"

Maybe there's an issue with preview environments at the moment? 🤷

[mrsimonemms]

/werft run

👍 started the job as gitpod-build-sje-cannot-delete-ws.8

[gtsiolis]

/werft run

👍 started the job as gitpod-build-sje-cannot-delete-ws.9

[gtsiolis]

/werft with-clean-slate-deployment

👎 unknown command: with-clean-slate-deployment
Use /werft help to list the available commands

[corneliusludmann]

Due to #4173 (comment):

Deleting workspaces in any phase but RUNNING or STOPPED is very difficult. I reckon we should rather disable the "Delete" item in the menu if the workspace is neither running nor stopped.

What about checking if the workspace is in RUNNING or STOPPED instead and only provide the delete button during these 2 phases?

→ This would probably fix this as well: https://community.gitpod.io/t/unable-to-delete-workspace/4956

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.