Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete a workspace in PREPARING phase #4173

Closed
gtsiolis opened this issue May 7, 2021 · 8 comments
Closed

Cannot delete a workspace in PREPARING phase #4173

gtsiolis opened this issue May 7, 2021 · 8 comments
Labels
component: dashboard groundwork: in review meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented May 7, 2021

Bug description

Users cannot delete workspaces in PREPARING phase.

Steps to reproduce

  1. Go to workspaces list (/workspaces)
  2. Create one or two workspaces. Using the example projects also works.
  3. Go back to the dashboard while workspaces are being created.
  4. Try to click more actions (···) and then Delete while a workspace is still in PREPARING phase.
  5. Confirm deletion in the confirmation modal.

Expected behavior

Workspace should be deleted.

According a reference to the comment in #4173 (comment).

We could either a) disable the workspace delete dropdown option or b) remove the entry from the user interface and handle all the background tasks needed to gracefully delete a workspace.

Example repository

No response

Anything else?

No response

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code labels May 7, 2021
@gtsiolis gtsiolis changed the title Cannot delete a workspacace in PREPARING phase Cannot delete a workspace in PREPARING phase May 7, 2021
@apolopena
Copy link

I have observed this issue as well.

@csweichel
Copy link
Contributor

Deleting workspaces in any phase but RUNNING or STOPPED is very difficult. I reckon we should rather disable the "Delete" item in the menu if the workspace is neither running nor stopped.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jul 5, 2021

I reckon we should rather disable the "Delete" item in the menu if the workspace is neither running nor stopped.

Thanks @csweichel for the insight! Agree, adding the following to the issue description. Let me know if the second option below sounds inefficient. 🏓

We could either a) disable the workspace delete dropdown option or b) remove the entry from the user interface and handle all the background tasks needed to gracefully delete a workspace.

@apolopena
Copy link

Previously a workspace could be deleted in any state, what changed? I assumed that (previously) the workspace was removed from the list until all the background tasks for deleting the workspace had been completed. I use to rely on this functionality, it was useful.

@csweichel
Copy link
Contributor

/schedule

@csweichel
Copy link
Contributor

Previously a workspace could be deleted in any state, what changed? I assumed that (previously) the workspace was removed from the list until all the background tasks for deleting the workspace had been completed. I use to rely on this functionality, it was useful.

Thank you for pointing this out. Except for "in preparation" workspaces in other phases can be stopped (which is what we're doing, actually). It would seem that the deletion doesn't happen reliably afterwards though, i.e. the workspace is stopped but not necessarily deleted).

@corneliusludmann
Copy link
Contributor

This seems to be related: https://community.gitpod.io/t/unable-to-delete-workspace/4956

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the meta: stale This issue/PR is stale and will be closed soon label May 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard groundwork: in review meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants