-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code] desktop support with 1.59 upgrade #5107
Conversation
12a0ad5
to
0576ca8
Compare
4817197
to
21d1e5d
Compare
/werft run 👍 started the job as gitpod-build-ak-remote-ssh.23 We need some smoke test on this PR for both targets regardless of whether we going with preview or not. Could someone test please? 🙏 |
21d1e5d
to
e025031
Compare
I get this everytime I start the TS / node example
|
In the local VS Code
|
I can only work with latest Gitpod Code Server running in the same workspace. |
e025031
to
95471b3
Compare
95471b3
to
7a4aa18
Compare
/werft run 👍 started the job as gitpod-build-ak-remote-ssh.28 |
/werft run 👍 started the job as gitpod-build-ak-remote-ssh.29 |
/lgtm |
LGTM label has been added. Git tree hash: 1ab88f0f8f5da3206607f3ecf4a69a09b64ae451
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, JanKoehnlein Associated issue: #4918 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What it does
Important! It depends on #4965
How to test
Switch to latest VS Code in setting before testing above.
Web
Start a new workspace and test following:
bundle.js
, reload the tab, confirm the app stops in the breakpoint while the original Gitpod tab remains functional.window.WebSocket.disconnectWorkspace()
, check that old websockets are closed and new opened of the same amountDesktop