Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User data of shared workspace override data of invited user #5151

Closed
akosyakov opened this issue Aug 11, 2021 · 5 comments
Closed

User data of shared workspace override data of invited user #5151

akosyakov opened this issue Aug 11, 2021 · 5 comments
Labels
editor: code (browser) feature: collaboration Features that enable collaboration across a shared workspace (e.g. multi-cursor) groundwork: scheduled meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working

Comments

@akosyakov
Copy link
Member

Bug description

Join another user workspace and then try to start another. You will see that your extensions now are overriden by owner extensions.

Steps to reproduce

See above.

Expected behavior

No response

Example repository

No response

Anything else?

No response

@akosyakov
Copy link
Member Author

akosyakov commented Aug 11, 2021

I think it is one line fix here: https://github.com/gitpod-io/vscode/blob/gp-code/extensions/gitpod-web/src/extension.ts#L121

i.e., it should be context.user not context.owner.

But we need to get #5107 first merged

@JanKoehnlein
Copy link
Contributor

/schedule

@akosyakov
Copy link
Member Author

We need to discuss how we can get for an invited user. I don't think there is a way right now.

@csweichel
Copy link
Contributor

It's unclear how much of a problem this is. Next step is to add analytics to controlAdmission, and to track cases where people actually join a shared workspace. We do this to find out how much workspace sharing is actually used.

Removing from groundwork for now.

@gtsiolis gtsiolis added feature: collaboration Features that enable collaboration across a shared workspace (e.g. multi-cursor) and removed feature: share running workspace labels Nov 23, 2021
@stale
Copy link

stale bot commented Feb 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 21, 2022
@stale stale bot closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: code (browser) feature: collaboration Features that enable collaboration across a shared workspace (e.g. multi-cursor) groundwork: scheduled meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants