Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Fix GitLab testEmptyProject test #4865

Merged
merged 1 commit into from
Jul 19, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions components/server/src/gitlab/gitlab-context-parser.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -531,19 +531,16 @@ class TestGitlabContextParser {
@test public async testEmptyProject() {
const result = await this.parser.handle({}, this.user, 'https://gitlab.com/gp-test-group/gp-test-empty-project');
expect(result).to.deep.include({
"ref": undefined,
"refType": undefined,
"revision": undefined,
"isFile": false,
"repository": {
"host": "gitlab.com",
"owner": "gp-test-group",
"name": "gp-test-empty-project",
"cloneUrl": "https://gitlab.com/gp-test-group/gp-test-empty-project.git",
"private": false,
"defaultBranch": null
"defaultBranch": "main"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is somehow independent, but I believe they broke the API if that's really true now for uninitialized repos. how can an empty repo has a branch?

},
"title": "gp-test-group/gp-test-empty-project"
"title": "gp-test-group/gp-test-empty-project - main"
})
}

Expand Down