Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Fix GitLab testEmptyProject test #4865

Merged
merged 1 commit into from
Jul 19, 2021
Merged

[server] Fix GitLab testEmptyProject test #4865

merged 1 commit into from
Jul 19, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Jul 19, 2021 •
edited
Loading

Fixes #4773

How to test:

  1. Create a GitLab token (api, read_user, read_repository)
  2. cd components/server
  3. export GITPOD_TEST_TOKEN_GITLAB='{"value": "YOUR-TOKEN"}'
  4. yarn test
  5. Verify result:
[...]

  69 passing (34s)
  59 pending

Done in 41.21s.

@roboquat roboquat requested a review from JanKoehnlein July 19, 2021 11:21
@corneliusludmann
Copy link
Contributor Author

/auto-cc

@roboquat roboquat requested a review from geropl July 19, 2021 11:30
@corneliusludmann corneliusludmann requested review from AlexTugarev and removed request for JanKoehnlein and geropl July 19, 2021 11:30
AlexTugarev
AlexTugarev reviewed Jul 19, 2021
View reviewed changes
components/server/src/gitlab/gitlab-context-parser.spec.ts
"isFile": false,
"repository": {
"host": "gitlab.com",
"owner": "gp-test-group",
"name": "gp-test-empty-project",
"cloneUrl": "https://gitlab.com/gp-test-group/gp-test-empty-project.git",
"private": false,
"defaultBranch": null
"defaultBranch": "main"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is somehow independent, but I believe they broke the API if that's really true now for uninitialized repos. how can an empty repo has a branch?

AlexTugarev
AlexTugarev approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing!

@roboquat roboquat added the lgtm label Jul 19, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13cfc6a0958961fc93f2800a1eaf8c6510c8cb4c

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, corneliusludmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0d98e36 into main Jul 19, 2021
@roboquat roboquat deleted the corneliusludmann/server-testemptyproject-4773 branch July 19, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees

@AlexTugarev AlexTugarev

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[server] testEmptyProject of the GitLab context parser fails
3 participants
@corneliusludmann @roboquat @AlexTugarev