Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Pull images if not present #4837

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

csweichel
Copy link
Contributor

This might speed up the workspace startup time

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat requested a review from rl-gitpod July 15, 2021 14:02
@csweichel csweichel force-pushed the cw/wsman-pullifnotpresent branch from 487a3b8 to bccb682 Compare July 15, 2021 14:05
@csweichel csweichel force-pushed the cw/wsman-pullifnotpresent branch from bccb682 to e8d1855 Compare July 15, 2021 14:09
@aledbf
Copy link
Member

aledbf commented Jul 15, 2021

/lgtm

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #4837 (e8d1855) into main (63108b7) will increase coverage by 36.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4837       +/-   ##
=========================================
+ Coverage      0   36.68%   +36.68%     
=========================================
  Files         0       13       +13     
  Lines         0     3669     +3669     
=========================================
+ Hits          0     1346     +1346     
- Misses        0     2206     +2206     
- Partials      0      117      +117     
Flag Coverage Δ
components-ws-manager-app 36.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go 78.64% <100.00%> (ø)
components/ws-manager/pkg/manager/manager.go 26.05% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/config.go 32.50% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.26% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 70.84% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 66.66% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go 74.46% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63108b7...e8d1855. Read the comment docs.

@csweichel csweichel marked this pull request as ready for review July 15, 2021 14:49
@csweichel
Copy link
Contributor Author

/woof

because why not

@roboquat
Copy link
Contributor

@csweichel: dog image

In response to this:

/woof

because why not

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roboquat roboquat merged commit ef090bb into main Jul 16, 2021
@roboquat roboquat deleted the cw/wsman-pullifnotpresent branch July 16, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants