[ws-manager] Pull images if not present

gitpod-io · Jul 15, 2021 · e8d1855 · e8d1855
1 parent 63108b7
commit e8d1855
Show file tree

Hide file tree

Showing 45 changed files with 45 additions and 45 deletions.
diff --git a/components/ws-manager/pkg/manager/create.go b/components/ws-manager/pkg/manager/create.go
@@ -468,7 +468,7 @@ func (m *Manager) createWorkspaceContainer(startContext *startWorkspaceContext)
 		Name:            "workspace",
 		Image:           image,
 		SecurityContext: sec,
-		ImagePullPolicy: corev1.PullAlways,
+		ImagePullPolicy: corev1.PullIfNotPresent,
 		Ports: []corev1.ContainerPort{
 			{ContainerPort: startContext.IDEPort},
 		},

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_admission.golden b/components/ws-manager/pkg/manager/testdata/cdwp_admission.golden
@@ -169,7 +169,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_empty_resource_req.golden b/components/ws-manager/pkg/manager/testdata/cdwp_empty_resource_req.golden
@@ -163,7 +163,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_fixedresources.golden b/components/ws-manager/pkg/manager/testdata/cdwp_fixedresources.golden
@@ -166,7 +166,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_fullworkspacebackup.golden b/components/ws-manager/pkg/manager/testdata/cdwp_fullworkspacebackup.golden
@@ -155,7 +155,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_ghost.golden b/components/ws-manager/pkg/manager/testdata/cdwp_ghost.golden
@@ -158,7 +158,7 @@
                         }
                     ],
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_prebuild.golden b/components/ws-manager/pkg/manager/testdata/cdwp_prebuild.golden
@@ -169,7 +169,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_prebuild_template.golden b/components/ws-manager/pkg/manager/testdata/cdwp_prebuild_template.golden
@@ -173,7 +173,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_prebuild_template_override_resources.golden b/components/ws-manager/pkg/manager/testdata/cdwp_prebuild_template_override_resources.golden
@@ -173,7 +173,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_probe.golden b/components/ws-manager/pkg/manager/testdata/cdwp_probe.golden
@@ -169,7 +169,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_readinessprobe.golden b/components/ws-manager/pkg/manager/testdata/cdwp_readinessprobe.golden
@@ -165,7 +165,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_tasks.golden b/components/ws-manager/pkg/manager/testdata/cdwp_tasks.golden
@@ -169,7 +169,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_template.golden b/components/ws-manager/pkg/manager/testdata/cdwp_template.golden
@@ -169,7 +169,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_timeout.golden b/components/ws-manager/pkg/manager/testdata/cdwp_timeout.golden
@@ -170,7 +170,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/cdwp_userns.golden b/components/ws-manager/pkg/manager/testdata/cdwp_userns.golden
@@ -165,7 +165,7 @@
                         "failureThreshold": 600
                     },
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/getWorkspaces_podOnly.json b/components/ws-manager/pkg/manager/testdata/getWorkspaces_podOnly.json
@@ -131,7 +131,7 @@
               }
             ],
             "image": "eu.gcr.io/gitpod-dev/workspace-images:a4d95e78185ee17b09e21a79939393f4eec08d6c247c1b52696172db0a6349f7",
-            "imagePullPolicy": "Always",
+            "imagePullPolicy": "IfNotPresent",
             "name": "workspace",
             "ports": [
               {

diff --git a/components/ws-manager/pkg/manager/testdata/status_brokenScheduler_UNKNOWN00.json b/components/ws-manager/pkg/manager/testdata/status_brokenScheduler_UNKNOWN00.json
@@ -174,7 +174,7 @@
                     },
                     "terminationMessagePath": "/dev/termination-log",
                     "terminationMessagePolicy": "File",
-                    "imagePullPolicy": "Always",
+                    "imagePullPolicy": "IfNotPresent",
                     "securityContext": {
                         "capabilities": {
                             "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_containerd4214_STOPPING00.json b/components/ws-manager/pkg/manager/testdata/status_containerd4214_STOPPING00.json
@@ -218,7 +218,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED01.json b/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED01.json
@@ -188,7 +188,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED02.json b/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED02.json
@@ -188,7 +188,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED03.json b/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPED03.json
@@ -188,7 +188,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPING01.json b/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPING01.json
@@ -191,7 +191,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPING02.json b/components/ws-manager/pkg/manager/testdata/status_disposal_STOPPING02.json
@@ -191,7 +191,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_errimgpull.json b/components/ws-manager/pkg/manager/testdata/status_errimgpull.json
@@ -161,7 +161,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_errimgpull_CREATING01.json b/components/ws-manager/pkg/manager/testdata/status_errimgpull_CREATING01.json
@@ -159,7 +159,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_failedBeforeStopping_explicitFail.json b/components/ws-manager/pkg/manager/testdata/status_failedBeforeStopping_explicitFail.json
@@ -173,7 +173,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_failedLogs_UNKNOWN00.json b/components/ws-manager/pkg/manager/testdata/status_failedLogs_UNKNOWN00.json
@@ -170,7 +170,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_failedPending_evicted_UNKNOWN01.json b/components/ws-manager/pkg/manager/testdata/status_failedPending_evicted_UNKNOWN01.json
@@ -96,7 +96,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_failedPending_evicted_UNKNOWN02.json b/components/ws-manager/pkg/manager/testdata/status_failedPending_evicted_UNKNOWN02.json
@@ -101,7 +101,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_failedTheiaMount_PENDING00.json b/components/ws-manager/pkg/manager/testdata/status_failedTheiaMount_PENDING00.json
@@ -170,7 +170,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_failedWorkspaceMount_PENDING00.json b/components/ws-manager/pkg/manager/testdata/status_failedWorkspaceMount_PENDING00.json
@@ -170,7 +170,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_firstUserActivity_RUNNING.json b/components/ws-manager/pkg/manager/testdata/status_firstUserActivity_RUNNING.json
@@ -98,7 +98,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_imagespec_RUNNING00.json b/components/ws-manager/pkg/manager/testdata/status_imagespec_RUNNING00.json
@@ -156,7 +156,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_interrupted.json b/components/ws-manager/pkg/manager/testdata/status_interrupted.json
@@ -159,7 +159,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_interrupted_CREATING00.json b/components/ws-manager/pkg/manager/testdata/status_interrupted_CREATING00.json
@@ -156,7 +156,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/...ents/ws-manager/pkg/manager/testdata/status_interrupted_networkNotReady_1_event_only.json b/...ents/ws-manager/pkg/manager/testdata/status_interrupted_networkNotReady_1_event_only.json
@@ -96,7 +96,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/...manager/pkg/manager/testdata/status_interrupted_networkNotReady_2_event_and_exitcode.json b/...manager/pkg/manager/testdata/status_interrupted_networkNotReady_2_event_and_exitcode.json
@@ -161,7 +161,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/...ager/pkg/manager/testdata/status_interrupted_networkNotReady_3_recovered_CONSTRUCTED.json b/...ager/pkg/manager/testdata/status_interrupted_networkNotReady_3_recovered_CONSTRUCTED.json
@@ -161,7 +161,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_ownerToken.json b/components/ws-manager/pkg/manager/testdata/status_ownerToken.json
@@ -100,7 +100,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_prebuildFail_STOPPED00.json b/components/ws-manager/pkg/manager/testdata/status_prebuildFail_STOPPED00.json
@@ -211,7 +211,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_prebuildFail_STOPPING00.json b/components/ws-manager/pkg/manager/testdata/status_prebuildFail_STOPPING00.json
@@ -206,7 +206,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/status_stuckInCreating_CREATING00.json b/components/ws-manager/pkg/manager/testdata/status_stuckInCreating_CREATING00.json
@@ -98,7 +98,7 @@
           },
           "terminationMessagePath": "/dev/termination-log",
           "terminationMessagePolicy": "File",
-          "imagePullPolicy": "Always",
+          "imagePullPolicy": "IfNotPresent",
           "securityContext": {
             "capabilities": {
               "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/stopping_basic.json b/components/ws-manager/pkg/manager/testdata/stopping_basic.json
@@ -99,7 +99,7 @@
                         },
                         "terminationMessagePath": "/dev/termination-log",
                         "terminationMessagePolicy": "File",
-                        "imagePullPolicy": "Always",
+                        "imagePullPolicy": "IfNotPresent",
                         "securityContext": {
                             "capabilities": {
                                 "add": [

diff --git a/components/ws-manager/pkg/manager/testdata/timeout_interrupted_noActivity.json b/components/ws-manager/pkg/manager/testdata/timeout_interrupted_noActivity.json
@@ -161,7 +161,7 @@
             },
             "terminationMessagePath": "/dev/termination-log",
             "terminationMessagePolicy": "File",
-            "imagePullPolicy": "Always",
+            "imagePullPolicy": "IfNotPresent",
             "securityContext": {
               "capabilities": {
                 "add": [