Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Additional fetch pinned workspace #4523

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Jun 16, 2021

Fixes #4488

Also fixes #4487 along the way while keeping #3879 fixed.

How to test

See issue #4488 on how to test this. Would probably make sense to change the limit to something like 3 here:

and run

cd components/dashboard/ && yarn telepresence

(otherwise starting > 50 workspaces to these this would not be that handy)

@corneliusludmann corneliusludmann force-pushed the clu/workspaces-list-2-4488 branch from 9636554 to f378e3a Compare June 16, 2021 14:09
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corneliusludmann corneliusludmann merged commit 85a704f into main Jun 16, 2021
@corneliusludmann corneliusludmann deleted the clu/workspaces-list-2-4488 branch June 16, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants