[dashboard] Additional fetch pinned workspace

Fixes #4488

CHANGELOG.md

@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
 
 ## June 2021
 
+- Fix active workspace list in dashboard (show also older pinned workspaces) ([#4523](https://github.com/gitpod-io/gitpod/pull/4523))
 - Adding `ItemsList` component as a more maintainable and consistent way to render a list of workspaces, git integrations, environment variables, etc. ([#4454](https://github.com/gitpod-io/gitpod/pull/4454))
 - Improve backup stability when pods get evicted ([#4405](https://github.com/gitpod-io/gitpod/pull/4405))
 - Fix text color in workspaces list for dark theme ([#4410](https://github.com/gitpod-io/gitpod/pull/4410))

components/dashboard/src/workspaces/workspace-model.ts

@@ -34,7 +34,15 @@ export class WorkspaceModel implements Disposable, Partial<GitpodClient> {
             limit: this.internalLimit
         }).then( infos => {
             this.updateMap(infos);
-            this.notifyWorkpaces();
+            // Additional fetch pinned workspaces
+            // see also: https://github.com/gitpod-io/gitpod/issues/4488
+            getGitpodService().server.getWorkspaces({
+                limit: this.internalLimit,
+                pinnedOnly: true,
+            }).then(infos => {
+                this.updateMap(infos);
+                this.notifyWorkpaces();
+            });
         });
         this.disposables.push(getGitpodService().registerClient(this));
     }
@@ -121,12 +129,14 @@ export class WorkspaceModel implements Disposable, Partial<GitpodClient> {
         infos = infos.sort((a,b) => {
            return WorkspaceInfo.lastActiveISODate(b).localeCompare(WorkspaceInfo.lastActiveISODate(a));
         });
-        this.setWorkspaces(infos);
+        this.setWorkspaces(infos.slice(0, this.internalLimit));
     }
 
     protected isActive(info: WorkspaceInfo): boolean {
-        return info.workspace.pinned ||
-            (!!info.latestInstance && !['stopping', 'stopped'].includes(info.latestInstance.status?.phase));
+        return (
+            info.workspace.pinned ||
+            (!!info.latestInstance && info.latestInstance.status?.phase !== 'stopped')
+        ) && !info.workspace.softDeleted;
     }
 
     public getAllFetchedWorkspaces(): Map<string, WorkspaceInfo> {