[dashboard] Add workspace status indicator color red for failed status #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusludmann
force-pushed
the
corneliusludmann/errored-workspaces-3635
branch
2 times, most recently
from
e3d7220 to
d387483
Compare
|
/werft run 👍 started the job as gitpod-build-corneliusludmann-errored-workspaces-3635.5 |
gtsiolis
reviewed
Jun 9, 2021
There was a problem hiding this comment.
Hey @corneliusludmann, do you know if there's an easy way to reproduce this erroneous state on the workspaces list?
Unfortunately, not. 😞 What you can do is to alter the database to add a failed condition (as JSON content, unfortunately, I don't have a query handy). However, it seems to me that the value of this is pretty limited since you don't really test how a failed workspace behaves. |
DEAL. Safe to merge this as is once conflicts are resolved? 🥝 |
gtsiolis
approved these changes
Jun 11, 2021
corneliusludmann
force-pushed
the
corneliusludmann/errored-workspaces-3635
branch
from
d387483 to
a79783a
Compare
|
I think it should be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3635