Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errored workspaces don't use the correct status indicator #3635

Closed
gtsiolis opened this issue Mar 28, 2021 · 3 comments · Fixed by #4378
Closed

Errored workspaces don't use the correct status indicator #3635

gtsiolis opened this issue Mar 28, 2021 · 3 comments · Fixed by #4378

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

The new dasboard surfaces errored workspaces without the correct status indicator.

Proposal

Use red-600 for the error status indicator.

BEFORE AFTER
image image
@gtsiolis gtsiolis added this to the March 2021 milestone Mar 28, 2021
@svenefftinge svenefftinge self-assigned this Mar 29, 2021
@svenefftinge svenefftinge reopened this Apr 7, 2021
@svenefftinge svenefftinge modified the milestones: March 2021, April 2021 Apr 12, 2021
@csweichel csweichel removed this from the April 2021 milestone May 6, 2021
@gtsiolis gtsiolis added the type: bug Something isn't working label Jun 1, 2021
@JanKoehnlein JanKoehnlein added this to the [backlog] June 2021 milestone Jun 1, 2021
@corneliusludmann
Copy link
Contributor

@gtsiolis Is it intended, that the interrupted state has color red-400 and the errored workspace you addressed in this issue should get the color red-600 as status indicator?

https://github.com/gitpod-io/gitpod/blob/7cc28f0acbe283ce7e6715fb3d2fc7753220f2dc/components/dashboard/src/workspaces/WorkspaceEntry.tsx#L156-L159

@corneliusludmann
Copy link
Contributor

What is with the unknown state? Currently, the status indicator is rendered with bg-gitpod-kumquat animate-pulse (the default, intended for workspaces that are in a transition phase). Should this state get a red indicator as well? The state description does not sound like a transition state but more like a final error state.

// unknown indicates an issue within the system in that it cannot determine the actual phase of
// a workspace. This phase is usually accompanied by an error.
"unknown" |

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 2, 2021

Is it intended, that the interrupted state has color ...

Hey @corneliusludmann! I think they can use the same red. I was going to suggest to move forward with the red-600 but let's go with red-500 and improve accessibility with color and shape in a later iteration in #4225. What do you think? 🍊

red-400 red-500 red-600
indicator-1 indicator-2 indicator-3

What is with the unknown state?

Not sure about this one but sounds safe to go with the same red, right? Looping in @jankeromnes @svenefftinge in case they can want add any further thoughts on this. 💬

... is rendered with bg-gitpod-kumquat

Starting and stopping phases can continue to use an orange-ish color. I think we can safely phase out custom colors like bg-gitpod-kumquat and replace it #FBBF24 from the colors.amber palette, see relevant docs. We did import colors.amber for the orange palette, however, feel free to leave this out of the scope of these changes.

orange: colors.amber,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants