Modify the "New Git Integration" experience to align with provider terminology #4287
Conversation
jordanhailey
changed the title
|
/werft run 👍 started the job as gitpod-build-jordanhailey-issue-4275-fork.0 |
…ted useEffect hook
… has not been modified
| useEffect(() => { | ||
| if (props.mode === "new") { | ||
| // If the host value has been modified e.g. not gitlab.example.com, assume it has been set by user and end operation | ||
| if (!host.includes(".example.com")) return; | ||
| const exampleHostname = `${type.toLowerCase()}.example.com`; | ||
| updateHostValue(exampleHostname); | ||
| } | ||
| }, [type]); |
There was a problem hiding this comment.
This hook is for a little UX improvement to modify host and redirectURL whenever the provider changes, that being said, I understand the team is following the Minimal Valuable Change approach and perhaps this creeps a bit beyond the scope of the issue I set out to address. If that's the case I am happy to remove the hook.
|
/werft run 👍 started the job as gitpod-build-jordanhailey-issue-4275-fork.1 |
|
Hey @jordanhailey! Thanks a lot for your contribution and sorry that it took so long to get feedback. We are still working on getting better at this. 😞 I really like your contribution and I am about to approve and merge this. Unfortunately, we need a signed CLA first for legal reasons and this process is not automated yet. 🙄 @meysholdt will contact you for this. Thanks for your patience! |
|
Thanks @corneliusludmann, I'm glad you like my small contribution. I got the docusign and executed the agreement on my end. Cheers |
|
hi @jordanhailey, I have received the signed CLA. Thank you! |
Per #4275, submitting same code as #4285 on a shorter branch name to fix build error.