Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Git Integration" dialog - Match field labels with the provider's naming #4275

Closed
mikenikles opened this issue May 22, 2021 · 2 comments
Closed

Comments

@mikenikles
Copy link
Contributor

When creating an OAuth app, GitLab and GitHub provide slightly different names for what we refer to as "Client ID" and "Client Secret" in the UI.

I suggest we display field labels depending on which provider is selected based on the following matrix:

GitLab GitHub
Client ID Application ID Client ID
Client Secret Secret Client secret

This change will make it easier to follow the instructions in the documentation as there is no need to explain the above mapping to readers.

@jordanhailey
Copy link
Contributor

Hey @mikenikles, following up from our chat in the Svelte Discord, hopefully this first contribution is helpful!

I couldn't figure out how to run an instance of Gitpod on my own Gitpod account. From looking over the forum I found a relevant post that seems to indicate that the team needs to initiate a build, after which in which I can get temporary access to run the application and see my changes? Let me know if that will be required for this change.

My solution was fairly straightforward, but there is one useEffect function I've added that should either be pulled out or ran through a QA review.

@gtsiolis
Copy link
Contributor

Resolved in #4287. Thanks @jordanhailey for contributing! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants