Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-image] Add support for pre-commit #4189

Merged
merged 4 commits into from
Jun 15, 2021
Merged

[dev-image] Add support for pre-commit #4189

merged 4 commits into from
Jun 15, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 10, 2021

Example of validation failure:
Screenshot from 2021-06-08 13-47-49

@aledbf
Copy link
Member Author

aledbf commented May 10, 2021

/werft run

👍 started the job as gitpod-build-aledbf-precommit.1

@aledbf
Copy link
Member Author

aledbf commented May 10, 2021

/werft run

👍 started the job as gitpod-build-aledbf-precommit.3

@aledbf aledbf force-pushed the aledbf/precommit branch 7 times, most recently from beaf06a to cae66ec Compare May 13, 2021 12:54
@aledbf aledbf force-pushed the aledbf/precommit branch 4 times, most recently from aca11aa to c4b28ed Compare June 8, 2021 17:54
@aledbf
Copy link
Member Author

aledbf commented Jun 11, 2021

/werft run

👍 started the job as gitpod-build-aledbf-precommit.21

@aledbf aledbf force-pushed the aledbf/precommit branch 2 times, most recently from 562598b to 68b1c54 Compare June 11, 2021 16:16
@aledbf
Copy link
Member Author

aledbf commented Jun 11, 2021

/werft run

👍 started the job as gitpod-build-aledbf-precommit.25

@aledbf aledbf force-pushed the aledbf/precommit branch 2 times, most recently from ef2ed97 to 3e4eb48 Compare June 12, 2021 15:34
@gitpod-io gitpod-io deleted a comment from codecov bot Jun 12, 2021
@aledbf aledbf marked this pull request as ready for review June 12, 2021 15:35
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than forking the jumanjihouse/pre-commit-hooks repo. this lgtm

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@aledbf aledbf force-pushed the aledbf/precommit branch from 3e4eb48 to 9bdbca4 Compare June 15, 2021 13:53
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #4189 (885caae) into main (9681a2b) will increase coverage by 33.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4189       +/-   ##
=========================================
+ Coverage      0   33.27%   +33.27%     
=========================================
  Files         0      112      +112     
  Lines         0    19073    +19073     
=========================================
+ Hits          0     6346     +6346     
- Misses        0    12166    +12166     
- Partials      0      561      +561     
Flag Coverage Δ
components-blobserve-app 28.40% <ø> (?)
components-common-go-lib 20.87% <ø> (?)
components-content-service-api-go-lib ∅ <ø> (?)
components-content-service-app 16.23% <ø> (?)
components-content-service-lib 16.23% <ø> (?)
components-ee-agent-smith-app 16.12% <ø> (?)
components-ee-kedge-app 43.96% <ø> (?)
components-ee-ws-scheduler-app 62.51% <ø> (?)
components-gitpod-cli-app 13.02% <ø> (?)
components-gitpod-protocol-go-lib ∅ <ø> (?)
components-image-builder-api-go-lib ∅ <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-licensor-lib 77.19% <ø> (?)
components-local-app-api-go-lib ∅ <ø> (?)
components-local-app-app-darwin ∅ <ø> (?)
components-local-app-app-linux ∅ <ø> (?)
components-local-app-app-windows ∅ <ø> (?)
components-registry-facade-api-go-lib ∅ <ø> (?)
components-registry-facade-app 8.88% <ø> (?)
components-registry-facade-lib 8.88% <ø> (?)
components-service-waiter-app ∅ <ø> (?)
components-supervisor-api-go-lib ∅ <ø> (?)
components-supervisor-app 36.95% <ø> (?)
components-workspacekit-app ∅ <ø> (?)
components-ws-daemon-api-go-lib ∅ <ø> (?)
components-ws-daemon-app 22.72% <ø> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)
components-ws-daemon-seccomp-profile-installer-app ∅ <ø> (?)
components-ws-manager-api-go-lib ∅ <ø> (?)
components-ws-manager-app 36.44% <ø> (?)
components-ws-manager-bridge-api-go-lib ∅ <ø> (?)
components-ws-proxy-app 65.95% <ø> (?)
dev-blowtorch-app ∅ <ø> (?)
dev-loadgen-app ∅ <ø> (?)
dev-poolkeeper-app ∅ <ø> (?)
dev-sweeper-app ∅ <ø> (?)
dev-version-manifest-app 83.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/gitpod-cli/cmd/root.go 0.00% <0.00%> (ø)
components/content-service/pkg/storage/storage.go 7.86% <0.00%> (ø)
...omponents/registry-facade/pkg/registry/imagecfg.go 0.00% <0.00%> (ø)
components/content-service/pkg/archive/tar.go 60.31% <0.00%> (ø)
components/ee/kedge/pkg/kedge/serve.go 0.00% <0.00%> (ø)
...mponents/ee/ws-scheduler/pkg/scheduler/strategy.go 55.81% <0.00%> (ø)
components/ee/ws-scheduler/pkg/scheduler/state.go 89.36% <0.00%> (ø)
...onents/content-service/pkg/initializer/download.go 76.31% <0.00%> (ø)
components/supervisor/pkg/supervisor/supervisor.go 0.00% <0.00%> (ø)
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9681a2b...885caae. Read the comment docs.

@aledbf aledbf force-pushed the aledbf/precommit branch from 128e586 to 7b003db Compare June 15, 2021 14:41
@aledbf
Copy link
Member Author

aledbf commented Jun 15, 2021

/werft run

👍 started the job as gitpod-build-aledbf-precommit.36

@aledbf aledbf merged commit 7f5a899 into main Jun 15, 2021
@aledbf aledbf deleted the aledbf/precommit branch June 15, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants