Fix shell script (shellcheck)

gitpod-io · Jun 11, 2021 · 3e4eb48 · 3e4eb48
1 parent 4825fae
commit 3e4eb48
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/components/ee/agent-smith/scripts/prepare-bpf-dev-environment.sh b/components/ee/agent-smith/scripts/prepare-bpf-dev-environment.sh
@@ -9,14 +9,14 @@ img_url="https://cloud-images.ubuntu.com/bionic/current/bionic-server-cloudimg-a
 script_dirname="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
 outdir="${script_dirname}/_output"
 
-rm -Rf $outdir
-mkdir -p $outdir
+rm -Rf "$outdir"
+mkdir -p "$outdir"
 
 curl -L -o "${outdir}/linux-image.deb" $vmlinux_url
 curl -L -o "${outdir}/linux-modules.deb" $modules_url
 curl -L -o "${outdir}/rootfs.tar.gz" $img_url
 
-cd $outdir
+cd "$outdir"
 
 tar -xvf rootfs.tar.gz
 

diff --git a/components/ee/agent-smith/scripts/scp.sh b/components/ee/agent-smith/scripts/scp.sh
@@ -1,3 +1,3 @@
 #!/usr/bin/env bash
 
-sshpass -p 'root' scp -o StrictHostKeychecking=no -P 2222 $@
+sshpass -p 'root' scp -o StrictHostKeychecking=no -P 2222 "$@"