[dashboard] Ask user for confirmation before deleting an env variable + validate duplicate name and scope #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run 👍 started the job as gitpod-build-jx-confirm-delete-variable.5 |
|
Looking at this now! 👀 |
gtsiolis
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Thank you so much for adding this @jankeromnes! I'm sure the confirmation modal for deleting environment variables will bring some joy to our community! 🌱
jankeromnes
force-pushed
the
jx/confirm-delete-variable
branch
from
07b1ddd to
1c718f5
Compare
jankeromnes
force-pushed
the
jx/confirm-delete-variable
branch
from
1c718f5 to
76180fd
Compare
|
Many thanks! Looks like this now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3604
Fixes #3942
See also draft spec